Uh oh!
There was an error while loading. Please reload this page.
fix(select): option not truncated correctly in multiple mode - #7857
Merged
Conversation
crisbeto
commented
Oct 17, 2017
MemberAuthor
Also bonus fun fact: Apparently Pokemon names can't be longer than 10 characters. |
mmalerba
commented
Oct 17, 2017
Contributor
I assume that fun fact is no accident, makes things easier on Nintendo developers ;) |
crisbetoforce-pushed
the
7211/select-truncation
branch
from
November 19, 2017 08:45
372c518 to
6ccdca6CompareCurrently, when the text of an option is truncated, it ends up removing everything except the ellipsis on Firefox, IE and Edge. These changes fix the truncation and simplify the option view. Relates to angular#7211.
crisbetoforce-pushed
the
7211/select-truncation
branch
from
November 20, 2017 20:45
6ccdca6 to
bca3c5bCompareThis issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when the text of an option is truncated, it ends up removing everything except the ellipsis on Firefox, IE and Edge. These changes fix the truncation and simplify the option view. This seems to have started happening after the switch to
mat-form-field.Relates to #7211.