Skip to content

fix(datepicker): correct DST issues on IE 11 - #7858

Merged
josephperrott merged 2 commits into
angular:masterfrom
mmalerba:dp-ie
Nov 7, 2017
Merged

fix(datepicker): correct DST issues on IE 11#7858
josephperrott merged 2 commits into
angular:masterfrom
mmalerba:dp-ie

Conversation

@mmalerba

@mmalerbammalerba commented Oct 17, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

fixes#7167
fixes#8228

@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 17, 2017
@mmalerba

mmalerba commented Oct 17, 2017

Copy link
Copy Markdown
ContributorAuthor

demo: https://mmalerba-demo1.firebaseapp.com/datepicker

crisbeto
crisbeto reviewed Oct 17, 2017
View reviewed changes
Comment threadsrc/lib/core/datetime/native-date-adapter.ts
super.setLocale(matDateLocale);

// IE does its own time zone correction, so we disable this on IE.
this.useUtcForDisplay = !platform.TRIDENT;

@crisbetocrisbetoOct 17, 2017•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Can this be feature-detected (e.g. creating a date and verifying that the time is correct)?
  2. Is it IE-exclusive or does it happen on Edge as well?

@mmalerbammalerbaOct 17, 2017

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Not really, it depends on the locale the user is in and when / if they have DST
  2. IE only

I also intentionally left this public so it can be overridden by users as an easy fix while I investigate any future bugs related to this

crisbeto
crisbeto approved these changes Oct 17, 2017
View reviewed changes

@crisbetocrisbeto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbetocrisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Oct 17, 2017
@mmalerbammalerba removed the action: merge The PR is ready for merge by the caretaker label Oct 17, 2017
@mmalerba

mmalerba commented Oct 17, 2017

Copy link
Copy Markdown
ContributorAuthor

need to fix test failures

@mmalerba

mmalerba commented Oct 17, 2017

Copy link
Copy Markdown
ContributorAuthor

tests are good now

@mmalerbammalerba added the action: merge The PR is ready for merge by the caretaker label Oct 17, 2017
@julianobrasiljulianobrasil mentioned this pull request Nov 2, 2017
Closed
@mmalerbammalerba added the P2 The issue is important to a large percentage of users, with a workaround label Nov 2, 2017
@mmalerbammalerba mentioned this pull request Nov 7, 2017
Closed
@josephperrott
josephperrott merged commit 2f2325a into angular:masterNov 7, 2017
@mmalerba
mmalerba deleted the dp-ie branch July 31, 2018 21:19
@angular-automatic-lock-bot

angular-automatic-lock-botBot commented Sep 9, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 9, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbetocrisbetocrisbeto approved these changes

Assignees

@crisbetocrisbeto

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License AgreementP2The issue is important to a large percentage of users, with a workaround

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

IE 11 Datepicker not working Day incorrect in datepicker

4 participants

@mmalerba@crisbeto@googlebot@josephperrott