Skip to content

build: autocomplete test failure in iOS Safari - #7906

Merged
tinayuangao merged 1 commit into
angular:masterfrom
crisbeto:autocomplete-test-failure
Oct 20, 2017
Merged

build: autocomplete test failure in iOS Safari#7906
tinayuangao merged 1 commit into
angular:masterfrom
crisbeto:autocomplete-test-failure

Conversation

@crisbeto

@crisbetocrisbeto commented Oct 19, 2017•
edited
Loading

Copy link
Copy Markdown
Member

Fixes an autocomplete test failure in iOS Safari 10.

@crisbetocrisbeto added the in progress This issue is currently in progress label Oct 19, 2017
@crisbetocrisbeto self-assigned this Oct 19, 2017
@crisbeto
crisbeto requested a review from kara as a code ownerOctober 19, 2017 19:08
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 19, 2017
@crisbetocrisbeto added pr: merge safe and removed in progress This issue is currently in progress labels Oct 19, 2017
@crisbetocrisbeto assigned tinayuangao and unassigned crisbetoOct 19, 2017
@crisbetocrisbeto changed the title wip: autocomplete test failure in iOS Safaribuild: autocomplete test failure in iOS SafariOct 19, 2017
@tinayuangao

tinayuangao commented Oct 19, 2017

Copy link
Copy Markdown
Contributor

LGTM

kara
kara approved these changes Oct 20, 2017
View reviewed changes

@karakara left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karakara added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Oct 20, 2017
@tinayuangao
tinayuangao merged commit 5c6e3df into angular:masterOct 20, 2017
@angular-automatic-lock-bot

angular-automatic-lock-botBot commented Sep 7, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 7, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@karakarakara approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tinayuangaotinayuangao

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@crisbeto@tinayuangao@kara@googlebot