Skip to content

fix(slide-toggle): height collapsing if component doesn't have a label - #8270

Merged
tinayuangao merged 1 commit into
angular:masterfrom
crisbeto:8264/slide-toggle-collapse
Nov 29, 2017
Merged

fix(slide-toggle): height collapsing if component doesn't have a label#8270
tinayuangao merged 1 commit into
angular:masterfrom
crisbeto:8264/slide-toggle-collapse

Conversation

@crisbeto

Copy link
Copy Markdown
Member

Fixes the slide label component collapsing down to 16px if it doesn't have a label.

Fixes#8264.

@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 7, 2017

@devversiondevversion left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@devversiondevversion added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Nov 7, 2017
@devversiondevversion removed their assignment Nov 11, 2017
@crisbeto
crisbetoforce-pushed the 8264/slide-toggle-collapse branch from d2aafa2 to 77ef20dCompareNovember 19, 2017 08:49
Fixes the slide label component collapsing down to 16px if it doesn't have a label.
Fixesangular#8264.
@crisbeto
crisbetoforce-pushed the 8264/slide-toggle-collapse branch from 77ef20d to 33dd94bCompareNovember 20, 2017 20:29
@tinayuangao
tinayuangao merged commit 8205cb2 into angular:masterNov 29, 2017
tinayuangao pushed a commit to tinayuangao/material2 that referenced this pull request Nov 29, 2017
angular#8270)
Fixes the slide label component collapsing down to 16px if it doesn't have a label.
Fixesangular#8264.
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 7, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MatSlideToggle without label is default styled such that it does not center correctly

4 participants

@crisbeto@devversion@googlebot@tinayuangao