Skip to content

docs: show additional interfaces - #8376

Merged
jelbourn merged 2 commits into
angular:masterfrom
devversion:docs/show-additional-interfaces
Nov 20, 2017
Merged

docs: show additional interfaces#8376
jelbourn merged 2 commits into
angular:masterfrom
devversion:docs/show-additional-interfaces

Conversation

@devversion

Copy link
Copy Markdown
Member
  • Shows additional interfaces in the Dgeni API documentation
  • Adds documentation for the RippleGlobalOptions

Closes#8298.

@devversiondevversion added docs This issue is related to documentation pr: needs review labels Nov 11, 2017
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 11, 2017
@devversion
devversionforce-pushed the docs/show-additional-interfaces branch 2 times, most recently from cc88010 to 521ffd4CompareNovember 11, 2017 12:02

@jelbournjelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to audit other interfaces for having proper docs before publishing once we merge this?

import {PropertyMemberDoc} from 'dgeni-packages/typescript/api-doc-types/PropertyMemberDoc';
import {NormalizedMethodMemberDoc} from './normalize-method-parameters';

export interface CategorizedClassLikeDoc extends ClassLikeExportDoc {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add descriptions for these?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are just simple modifications to the real Dgeni documents - added comments to all of the modified definitions in this file.

@devversion
devversionforce-pushed the docs/show-additional-interfaces branch from 521ffd4 to a5ccacbCompareNovember 14, 2017 18:16

@jelbournjelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbournjelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Nov 14, 2017
* Shows additional interfaces in the Dgeni API documentation
* Adds documentation for the `RippleGlobalOptions`
Closesangular#8298.
@devversion
devversionforce-pushed the docs/show-additional-interfaces branch from a5ccacb to 4b5f835CompareNovember 19, 2017 09:09
@jelbourn
jelbourn merged commit 3b41005 into angular:masterNov 20, 2017
@devversion
devversion deleted the docs/show-additional-interfaces branch November 20, 2017 19:26
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 7, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License AgreementdocsThis issue is related to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Global Disable Ripple Does Not Affect Keyboard Focus

3 participants

@devversion@jelbourn@googlebot