Uh oh!
There was an error while loading. Please reload this page.
refactor(overlay): use key event dispatcher for CdkConnectedOverlay - #8531
Merged
jelbourn merged 1 commit intoJan 8, 2018
Merged
Conversation
crisbetoforce-pushed
the
overlay-directive-dispatcher-again
branch
2 times, most recently
from
November 30, 2017 21:55
0f1d130 to
a2e41c3Compareandrewseguin
commented
Dec 13, 2017
Contributor
Can you check the lint error and CI errors |
crisbetoforce-pushed
the
overlay-directive-dispatcher-again
branch
from
December 14, 2017 19:08
a2e41c3 to
a6e6ca9Comparecrisbeto
commented
Dec 14, 2017
MemberAuthor
Sorted out the lint warnings, the unit test failures are coming in from master. |
jelbourn
commented
Jan 8, 2018
Contributor
@crisbeto this passes presubmit, but looks like unit tests are failing on travis |
Switched the `CdkConnectedOverlay` directive to use the key event dispatcher rather than listening to events on the document.
crisbetoforce-pushed
the
overlay-directive-dispatcher-again
branch
from
January 8, 2018 18:09
a6e6ca9 to
fc499c6Comparecrisbeto
commented
Jan 8, 2018
MemberAuthor
Looks like a rebase resolved it @jelbourn. |
jelbourn pushed a commit
to jelbourn/components
that referenced
this pull request
Jan 8, 2018
…ngular#8531) Switched the `CdkConnectedOverlay` directive to use the key event dispatcher rather than listening to events on the document.
jelbourn pushed a commit
to jelbourn/components
that referenced
this pull request
Jan 9, 2018
…ngular#8531) Switched the `CdkConnectedOverlay` directive to use the key event dispatcher rather than listening to events on the document.
jelbourn pushed a commit
that referenced
this pull request
Jan 9, 2018
…8531) Switched the `CdkConnectedOverlay` directive to use the key event dispatcher rather than listening to events on the document.
tinayuangao pushed a commit
that referenced
this pull request
Jan 10, 2018
…8531) Switched the `CdkConnectedOverlay` directive to use the key event dispatcher rather than listening to events on the document.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switched the
CdkConnectedOverlaydirective to use the key event dispatcher rather than listening to events on the document.