Uh oh!
There was an error while loading. Please reload this page.
refactor: remove the OverlayContainer stubs from all of the tests - #8674
Merged
Merged
Conversation
crisbeto
requested review from
andrewseguin, jelbourn and kara
as code ownersNovember 27, 2017 21:58
tinayuangao
commented
Nov 28, 2017
Contributor
@crisbeto please rebase. Thanks! |
Gets rid of all the manual stubs of the `OverlayContainer` in the tests and replaces them with getting the container through DI. This removes some boilerplate and should make things less prone to breaking if we make any changes to the container.
crisbetoforce-pushed
the
overlay-container-override
branch
from
November 28, 2017 18:42
15b34a6 to
2336526Comparecrisbeto
commented
Nov 28, 2017
MemberAuthor
Rebased @tinayuangao. |
tinayuangao pushed a commit
to tinayuangao/material2
that referenced
this pull request
Nov 29, 2017
…gular#8674) Gets rid of all the manual stubs of the `OverlayContainer` in the tests and replaces them with getting the container through DI. This removes some boilerplate and should make things less prone to breaking if we make any changes to the container.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gets rid of all the manual stubs of the
OverlayContainerin the tests and replaces them with getting the container through DI. This removes some boilerplate and should make things less prone to breaking if we make any changes to the container.