Skip to content

fix(connected-position-strategy): allow positions to be updated after init - #8800

Merged
andrewseguin merged 1 commit into
angular:masterfrom
crisbeto:overlay-update-position
Dec 13, 2017
Merged

fix(connected-position-strategy): allow positions to be updated after init#8800
andrewseguin merged 1 commit into
angular:masterfrom
crisbeto:overlay-update-position

Conversation

@crisbeto

Copy link
Copy Markdown
Member

Backports the ability to update a connected overlay's positioning from the new flexible connected position strategy. This helps facilitate cases like #8653 without having to overwrite the entire position strategy.

… init
Backports the ability to update a connected overlay's positioning from the new flexible connected position strategy. This helps facilitate cases like angular#8653 without having to overwrite the entire position strategy.
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 4, 2017

@jelbournjelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbournjelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed pr: needs review labels Dec 5, 2017
@crisbetocrisbeto added target: patch This PR is targeted for the next patch release and removed target: minor This PR is targeted for the next minor release labels Dec 6, 2017
@andrewseguin
andrewseguin merged commit b7071ba into angular:masterDec 13, 2017
andrewseguin pushed a commit to andrewseguin/components that referenced this pull request Dec 19, 2017
… init (angular#8800)
Backports the ability to update a connected overlay's positioning from the new flexible connected position strategy. This helps facilitate cases like angular#8653 without having to overwrite the entire position strategy.
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 7, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreementtarget: patchThis PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@crisbeto@jelbourn@googlebot@andrewseguin