Uh oh!
There was an error while loading. Please reload this page.
fix(progress-bar): remove data url from progress-bar's css styling - #8898
Merged
Conversation
crisbeto
reviewed
Dec 8, 2017
| <div class="mat-progress-bar-background mat-progress-bar-element"> | ||
| <svg width="100%" height="5"> | ||
| <defs> | ||
| <pattern id="circle" x="5" y="0" width="10" height="5" patternUnits="userSpaceOnUse"> |
| * then placed back into the DOM again. This is necessary as the browser only defines the | ||
| * styling of SVG pattern elements as it is placed into the DOM. | ||
| */ | ||
| private _reappendCircleSvgElement() { |
Member
There was a problem hiding this comment.
I'm not convinced that this is necessary. The progress spinner supports changing the colors without having to re-append the element to the DOM. Are you sure that it doesn't have something to do with the circles not having a unique id?
josephperrottforce-pushed
the
progres-bar
branch
3 times, most recently
from
December 8, 2017 22:17
e6cc39d to
97f8482Compare| <div class="mat-progress-bar-background mat-progress-bar-element"> | ||
| <svg width="100%" height="5"> | ||
| <defs> | ||
| <pattern id="{{progressbarId}}" x="5" y="0" width="10" height="5" patternUnits="userSpaceOnUse"> |
Contributor
There was a problem hiding this comment.
Use [id] instead of interpolation?
| background-size: 10px 4px; | ||
| display: none; | ||
| svg { | ||
| position: absolute; |
Contributor
There was a problem hiding this comment.
Also comment on why the element is absolute?
josephperrottforce-pushed
the
progres-bar
branch
from
December 13, 2017 17:17
97f8482 to
2b4e1bfComparejosephperrottforce-pushed
the
progres-bar
branch
2 times, most recently
from
December 15, 2017 19:23
8ec3e4b to
237b400Comparejosephperrottforce-pushed
the
progres-bar
branch
from
January 8, 2018 18:26
237b400 to
3bd2224Comparejosephperrottforce-pushed
the
progres-bar
branch
from
January 17, 2018 20:06
3bd2224 to
a77110dComparejosephperrottforce-pushed
the
progres-bar
branch
2 times, most recently
from
January 25, 2018 16:23
a3a7515 to
32ae3b0Comparejosephperrottforce-pushed
the
progres-bar
branch
from
January 25, 2018 16:24
32ae3b0 to
bb3bdb3Comparejosephperrott
commented
Jan 25, 2018
MemberAuthor
@jelbourn ready for another look when you have a moment. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#8876