Skip to content

feat(checkbox): expose ripple instance - #9176

Merged
jelbourn merged 1 commit into
angular:masterfrom
devversion:feat/checkbox-expose-ripple
Jan 23, 2018
Merged

feat(checkbox): expose ripple instance#9176
jelbourn merged 1 commit into
angular:masterfrom
devversion:feat/checkbox-expose-ripple

Conversation

@devversion

@devversiondevversion commented Dec 31, 2017

Copy link
Copy Markdown
Member
  • Exposes the reference to the MatRipple directive publically.

Similar to #9170. References #4179

* Exposes the reference to the `MatRipple` directive publically.
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 31, 2017
@jelbourn

Copy link
Copy Markdown
Contributor

This seems out of sync with the discussion in #4179, no?

@devversion

devversion commented Jan 3, 2018

Copy link
Copy Markdown
MemberAuthor

The PR should resolve #4179. It's not the implementation of the last idea (with the mixins), which intends to provide another public API for the ripples.

In my opinion, if we should expose the ripple instance, then it should be really the MatRipple and no wrapper, that just provides a nicer API.

Since there is a overview file for the ripple now, I think that it would be fine just exposing the instance. Also, as I mentioned in #9170, we can add a guide that shows how to control ripples of components that expose the instance.

@jelbournjelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbournjelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed pr: needs review labels Jan 12, 2018
@jelbourn
jelbourn merged commit e09c0a6 into angular:masterJan 23, 2018
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 8, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreementtarget: minorThis PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@devversion@jelbourn@googlebot@tinayuangao