Uh oh!
There was an error while loading. Please reload this page.
chore(promises): Wait for promises explicitly - #70
Conversation
d45aa6e to
4ab4f2fCompare| } | ||
| } | ||
| }, flow); | ||
| }, 'Run ' + fnName + description + ' in control flow').then(seal(done), function(err) { |
There was a problem hiding this comment.
The seal function isn't used any more, so its declaration can be removed.
| flow.execute(function controlFlowExecute() { | ||
| return new webdriver.promise.Promise(function(fulfill, reject) { | ||
| function wrappedReject(err) { |
| /** | ||
| * Wraps a function so it runs inside a webdriver.promise.ControlFlow and | ||
| * waits for the flow to complete before continuing. |
There was a problem hiding this comment.
not related to this PR: only one param of the 3 is documented
| it('test B', () => { | ||
| currentTest = 'B'; | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Would be nice to test the error handling code paths somehow too.
4b57ea0 to
c67de4aCompare| expect(fakeDriver.getDecimalNumber()).not.toBeCloseTo(3.14); | ||
| }); | ||
| describe('native promises', function() { |
There was a problem hiding this comment.
@thorn0 this look good for error handling tests?
There was a problem hiding this comment.
Yes, thanks. There is also all this code for dealing with stack traces though...
There was a problem hiding this comment.
You want me to double check that the stack trace is correct?
There was a problem hiding this comment.
Never mind. That code appeared to me more complicated than it actually is. Let's merge this. 👍
| err = new Error('Unknown Error'); | ||
| err.stack = ''; | ||
| } | ||
| err.stack = err.stack + '\nFrom asynchronous test: \n' + driverError.stack; |
There was a problem hiding this comment.
We might want to call flow.reset() here instead of waiting for idle. What do you think?
There was a problem hiding this comment.
Why would we want to reset? If there are pending webdriver tasks we probably want to wait on them
There was a problem hiding this comment.
If we know that the test has already failed and we can cancel those tasks, why execute them? But I'm not sure. Let's leave it as it is.
| * Wraps a function so it runs inside a webdriver.promise.ControlFlow and | ||
| * waits for the flow to complete before continuing. | ||
| * @param {!webdriver.promise.ControlFlow} flow The WebDriver control flow | ||
| * @param {!Function} globalFn The function to wrap. |
There was a problem hiding this comment.
- Nit: address spelling.
- Nit: should end comment with a period.
| if (!err) { | ||
| err = new Error('Unknown Error'); | ||
| err.stack = ''; | ||
| } |
There was a problem hiding this comment.
Why not add fnName and description to this information for it to be a bit easier to identify errors?
err.stack+='\nFrom asynchronous test '+fnName+description+': \n'+driverError.stack;There was a problem hiding this comment.
jasmine adds that information automatically when we call done.fail
sjelin
commented
Dec 5, 2016
@cnishina you wanna review this? |
| /** | ||
| * Wraps a function so it runs inside a webdriver.promise.ControlFlow and | ||
| * waits for the flow to complete before continuing. |
There was a problem hiding this comment.
Nit: should end comment with a period.
| * Wraps a function so it runs inside a webdriver.promise.ControlFlow and | ||
| * waits for the flow to complete before continuing. | ||
| * @param {!webdriver.promise.ControlFlow} flow The WebDriver control flow | ||
| * @param {!Function} globalFn The function to wrap. |
There was a problem hiding this comment.
- Nit: address spelling.
- Nit: should end comment with a period.
See angular#68 for details
sjelin
commented
Dec 6, 2016
@cnishina all comments addressed. Can I have an LGTM? 😄 |
See #68 for details