Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Oct 17, 2025. It is now read-only.
feat(SELENIUM_PROMISE_MANAGER): Don't rely on webdriver.promise fun… - #82
Merged
Conversation
juliemr
commented
Jan 20, 2017
Member
Please change the commit message to mention "utility function which will be going away after the control flow has been fully deprecated." |
sjelin
commented
Jan 21, 2017
ContributorAuthor
@juliemr done |
juliemr
approved these changes
Jan 21, 2017
| newPromise = function(resolver) { | ||
| return new Promise(resolver); | ||
| }; | ||
| } |
Member
There was a problem hiding this comment.
For code readability flow, could you change the above to:
if(!scheduler){scheduler={execute: function(fn){returnPromise.resolve().then(fn);}}}if(typeofscheduler.promise=='function'){newPromise=scheduler.promise.bind(scheduler);}else{// what you have now...}sjelin
commented
Jan 21, 2017
sjelin
commented
Jan 21, 2017
| Your scheduler must emit `"idle"` when it becomes idle. | ||
| ### Reset API |
ContributorAuthor
There was a problem hiding this comment.
@juliemr this was also added since your review
juliemr
reviewed
Jan 21, 2017
| } | ||
| // Figure out how we're getting new promises | ||
| var newPromise; |
Member
There was a problem hiding this comment.
I like not using try/catch. Works for me!
| jasminewd will automatically look for a `reset` function and call it when specs time out. This is | ||
| useful so that if a spec executes a task that hangs, only that spec will timeout (as opposed to | ||
| tying up the scheduler and causing all future specs to timeout). |
Member
There was a problem hiding this comment.
And more generally, so that if a spec times out but has lingering commands, those get cleared instead of executing in random future tests.
…ctions While we support `SELENIUM_PROMISE_MANAGER=0` already, we rely on `SimpleScheduler` and some other utility functions which will be going away after the control flow has been fully deprecated. This commit allows jasminewd to work without those utility functions, and even allows people to pass jasminewd their own custom scheduler implementation. This does not fix our tests, which will also break when those utility functions go away. See angular#81Closesangular#80
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ctions
While we support
SELENIUM_PROMISE_MANAGER=0already, we rely onSimpleSchedulerand some otherutility functions which will be going away. This allows jasminewd to work without those utility
functions, and even allows people to pass jasminewd their own custom scheduler implementation.
This does not fix our tests, which will also break when those utility functions go away. See
#81
Closes#80