Uh oh!
There was an error while loading. Please reload this page.
chore(tests): Add unit tests for each component. - #138
Conversation
jelbourn
commented
Mar 31, 2017
Looks like CI is failing on an scss issue |
I believe the scss issue was due to it building with |
466fdf1 to
717a1f3Compare
jelbourn
left a comment
There was a problem hiding this comment.
Looks good, just a few tests that I think we can cut.
| "@angular/forms": "^2.4.6", | ||
| "@angular/http": "^2.4.6", | ||
| "@angular/material": "^2.0.0-beta.1", | ||
| "@angular/material": "^2.0.0-beta.2", |
There was a problem hiding this comment.
Can revert this line now that we're on beta.3
| fixture.detectChanges(); | ||
| })); | ||
| it('should render four rows of content on the homepage', () => { |
There was a problem hiding this comment.
I don't think we need these homepage tests since it's all just static content.
| .querySelector('.docs-footer-links a'); | ||
| const href = link.getAttribute('href'); | ||
| const text = link.textContent; | ||
| expect(~href.indexOf('angular.io')).toBeTruthy(); |
There was a problem hiding this comment.
Should be able to do
expect(href).toContain('angular.io');| expect(text).toContain('Learn Angular'); | ||
| }); | ||
| it('should show an angular logo in the footer', () => { |
There was a problem hiding this comment.
I don't think a test for the this is necessary
| fixture.detectChanges(); | ||
| })); | ||
| it('should have four main links', () => { |
There was a problem hiding this comment.
I think this test also isn't needed
b85ea7a to
616a64dCompare
No description provided.