Uh oh!
There was an error while loading. Please reload this page.
feat(license): add license component to display full license - #598
feat(license): add license component to display full license#598mamichels wants to merge 4 commits into
Conversation
EdricChan03
left a comment
There was a problem hiding this comment.
Nice to see a dedicated page for the license, but there's a couple of small nitpicks that should be fixed before it can be merged.
| @@ -0,0 +1,21 @@ | |||
| <div class="license-content"> | |||
| <p class="license-title">The MIT License</p> | |||
| <p>Copyright (c) 2010-2019 Google LLC. <a href="license">http://material.angular.io/license</a></p> | |||
There was a problem hiding this comment.
Would be a good idea to use routerLink here instead of a href tag
| import {FooterModule} from '../../shared/footer/footer'; | ||
| import {RouterModule} from '@angular/router'; | ||
| import {ComponentPageTitle} from '../page-title/page-title'; | ||
| import { LicenseModule } from '../license/license'; |
There was a problem hiding this comment.
Please remove the spaces surrounding the import.
| import{LicenseModule}from'../license/license'; | |
| import{LicenseModule}from'../license/license'; |
| @@ -0,0 +1,16 @@ | |||
| import { Component, NgModule } from "@angular/core"; | |||
There was a problem hiding this comment.
This file should be indented with 2 spaces instead of 4 and use single quotes instead of double quotes as well as removing the spaces from your import statements.
| @@ -0,0 +1,16 @@ | |||
| @import '../../../styles/constants'; | |||
There was a problem hiding this comment.
This file should be indented with 2 spaces instead of 4.
| @@ -1,5 +1,7 @@ | |||
| import {Component, NgModule} from '@angular/core'; | |||
| import {materialVersion} from '../version/version'; | |||
| import { RouterModule } from '@angular/router'; | |||
There was a problem hiding this comment.
Please remove the spaces surrounding the import.
| import{RouterModule}from'@angular/router'; | |
| import{RouterModule}from'@angular/router'; |
| @NgModule({ | ||
| imports: [RouterModule.forRoot(MATERIAL_DOCS_ROUTES)], |
There was a problem hiding this comment.
Please use RouterModule#forChild instead of RouterModule#forRoot on submodules/lazy-loaded modules (as indicated in the API docs for RouterModule).
| imports: [RouterModule.forRoot(MATERIAL_DOCS_ROUTES)], | |
| imports: [RouterModule.forChild(MATERIAL_DOCS_ROUTES)], |
| import {Component, NgModule} from '@angular/core'; | ||
| import {materialVersion} from '../version/version'; | ||
| import { RouterModule } from '@angular/router'; | ||
| import { MATERIAL_DOCS_ROUTES } from '../../routes'; |
There was a problem hiding this comment.
Please remove the spaces surrounding the import.
| import{MATERIAL_DOCS_ROUTES}from'../../routes'; | |
| import{MATERIAL_DOCS_ROUTES}from'../../routes'; |
Adding the full license aggreement as per angular.io example in reference to angular/components#16039