Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

docs(dialog): added docs to the elements and fixed controller - #5957

Closed
EladBezalel wants to merge 1 commit into
masterfrom
docs/dialog-directive
Closed

docs(dialog): added docs to the elements and fixed controller#5957
EladBezalel wants to merge 1 commit into
masterfrom
docs/dialog-directive

Conversation

@EladBezalel

@EladBezalelEladBezalel commented Nov 27, 2015

Copy link
Copy Markdown
Member

Added md-dialog directive page that contains - md-dialog, md-dialog-content, md-dialog-actions.
Added function type to controller method

fixes#4728 and #3199

@EladBezalelEladBezalel added the needs: review This PR is waiting on review from the team label Nov 27, 2015
devversion
devversion reviewed Nov 27, 2015
View reviewed changes
Comment threadsrc/components/dialog/dialog.js Outdated

@devversiondevversionNov 27, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should change that text (Css) to upper case right? As here?

The rest looks perfect 😄

@EladBezalelEladBezalelNov 27, 2015

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@EladBezalel
docs(dialog): added docs to the elements and fixed controller
3fb456f
Added `md-dialog` directive page that contains - `md-dialog`, `md-dialog-content`, `md-dialog-actions`.
Added `function` type to controller method
fixes#4728 and #3199
@ThomasBurlesonThomasBurleson added pr: merge ready This PR is ready for a caretaker to review and removed needs: review This PR is waiting on review from the team labels Dec 2, 2015
@ThomasBurlesonThomasBurleson added this to the 1.0-rc6 milestone Dec 2, 2015
@ThomasBurlesonThomasBurleson self-assigned this Dec 2, 2015
@EladBezalel
EladBezalel deleted the docs/dialog-directive branch December 3, 2015 17:34
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@ThomasBurlesonThomasBurleson

Labels

pr: merge readyThis PR is ready for a caretaker to review

Projects

None yet

Milestone

1.0-rc6

Development

Successfully merging this pull request may close these issues.

md-dialog and md-dialog-content are not documented

3 participants

@EladBezalel@devversion@ThomasBurleson