Uh oh!
There was an error while loading. Please reload this page.
fix(layout): allow layout-align without cross-axis value - #6003
Conversation
* fix parsing issue to allow single value * add demo to test omitting second value fixesangular#5996
ThomasBurleson
commented
Dec 2, 2015
@ngraef - this is not ideal. Allowing a mainAxis-only is fine, but the style should always fallback to defaults:
If you update the demos accordingly, I will merge.
|
ngraef
commented
Dec 2, 2015
@ThomasBurleson I'm confused about what needs work. This doesn't change anything about the default values or the fallback behavior during parsing. |
ThomasBurleson
commented
Dec 2, 2015
@ngraef - This PR is incomplete:
|
ngraef
commented
Dec 2, 2015
|
ThomasBurleson
commented
Dec 2, 2015
@ngraef - I think my current Flu is confusing me; since I wrote if(ALIGNMENT_MAIN_AXIS.indexOf(axis.main)<0)axis.main="start";if(ALIGNMENT_CROSS_AXIS.indexOf(axis.cross)<0)axis.cross="stretch";LOL. Thank you for the clear and reasonable follow-up. |
ngraef
commented
Dec 2, 2015
@ThomasBurleson - No problem. Thanks for reviewing. |
fixes#5996