Uh oh!
There was an error while loading. Please reload this page.
fix(input): match up all label transitions - #6400
Conversation
Change all label `transitions` to be `0.25s` long, as the default is. Fixesangular#6328
googlebot
commented
Dec 19, 2015
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
tjlav5
commented
Dec 19, 2015
I signed it! |
googlebot
commented
Dec 19, 2015
CLAs look good, thanks! |
ThomasBurleson
commented
Dec 21, 2015
@topherfangio - needs review and validation with Spec. |
topherfangio
commented
Dec 21, 2015
Spec-wise, I think this is compliant (I can't find anything that specifies exactly what it should be). However, since we're using a special timing, I'd like to see it as a variable (perhaps |
tjlav5
commented
Dec 28, 2015
@topherfangio good point. I'll consolidate under a variable tonight. Cheers |
tjlav5
commented
Dec 28, 2015
@topherfangio considering that the transitions all use the $swift-ease-out-timing-function, should the timing duration ALSO be using $swift-ease-out-duration? |
Use the `$swift-ease-out-duration` in conjunction with the `$swift-ease-out-timing-function`
topherfangio
commented
Jan 6, 2016
@tjlav5 Yes, it should use the ease-out duration. Thanks for updating! I am restarting the Travis build to ensure all the tests pass (there was an unrelated build issue which was causing the failure). |
EladBezalel
commented
Jan 9, 2016
Bumped to Topher as it seems that he's in charge here 😄 |
ThomasBurleson
commented
Feb 1, 2016
@tjlav5 - please Rebase with latest from |
tjlav5
commented
Feb 4, 2016
@ThomasBurleson sorry missed the rebase request. But it looks like you handled it. |
- Thx @tjlav5Fixesangular#6328. Closesangular#6400.
Change all label
transitionsto be0.25slong, as the default is.Fixes#6328