Skip to content
This repository was archived by the owner on Oct 12, 2021. It is now read-only.

feat(AppShell): shellRender and shellNoRender attributes and allow different element stripping strategies - #81

Open
mgechev wants to merge 1 commit into
angular:masterfrom
mgechev:app-shell-directives
Open

feat(AppShell): shellRender and shellNoRender attributes and allow different element stripping strategies#81
mgechev wants to merge 1 commit into
angular:masterfrom
mgechev:app-shell-directives

Conversation

@mgechev

Copy link
Copy Markdown
Member
  • Make the shell-related directives add shellRender and shellNoRender attributes.
  • Encapsulate the "hiding", "showing" element logic into a service which is injected with DI and can its provider can be overridden.
  • Add visitor which finds App Shell related comments in templates and processes them.

@mgechev
mgechevforce-pushed the app-shell-directives branch 2 times, most recently from 9e2c349 to 34e3399CompareJuly 8, 2016 11:55
@mgechev

Copy link
Copy Markdown
MemberAuthor

Fixes #71.

@mgechev
mgechevforce-pushed the app-shell-directives branch 2 times, most recently from cc3259d to d92257bCompareJuly 10, 2016 13:39
@mgechev

Copy link
Copy Markdown
MemberAuthor

Note that in a browser environment, the DOM adapter needs to be explicitly set:

import{BrowserDomAdapter}from'@angular/platform-browser/src/browser/browser_adapter';BrowserDomAdapter.makeCurrent();

@mgechev
mgechevforce-pushed the app-shell-directives branch 2 times, most recently from 823e18a to 2c18098CompareSeptember 14, 2016 19:01
…t different stripping strategies
- [x] Make the shell-related directives add `shellRender` and `shellNoRender` attributes.
- [x] Encapsulate the "hiding", "showing" element logic into a service which is injected with DI and can its provider can be overridden.
- [x] Add visitor which finds App Shell related comments in templates and processes them.
- [x] Remove useless imports.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mgechev@jeffbcross