Uh oh!
There was an error while loading. Please reload this page.
docs(AppShell): add guide for the App Shell Runtime Parser - #84
Conversation
| import { provide } from '@angular/core'; | ||
| import { APP_BASE_HREF } from '@angular/common'; | ||
| import { APP_SHELL_RUNTIME_PROVIDERS } from '@angular/app-shell'; | ||
| import { HelloMobileAppComponent } from './app/'; |
There was a problem hiding this comment.
Should this be ./app/hello-mobile.component?
There was a problem hiding this comment.
There's a barrel generated by the CLI.
There was a problem hiding this comment.
I think it'd look nicer without the trailing slash, './app'
ca2103d to
8967411Compare| context.ngShellParser.match(event.request) | ||
| .then((response: any) => { | ||
| if (response) return response; | ||
| return (<any>self).caches.match(event.request) |
There was a problem hiding this comment.
Couldn't you use context here (instead of <any>self)?
8967411 to
2734416Compare| .then(() => context.ngShellParser.fetchDoc()) | ||
| .then((res: any) => context.ngShellParser.parseDoc(res)) | ||
| .then((strippedResponse: any) => { | ||
| return (<any>self).caches.open(SHELL_PARSER_CACHE_NAME) |
b201161 to
4d680e2Comparemgechev
commented
Jul 11, 2016
All the comments are addressed. Let me know if you find anything else. |
| Now we're going to take a look at another part of the Angular Mobile Toolkit - the App Shell Runtime Parser. The Runtime Parser is a library which has the following features: | ||
| - Automatically generates the App Shell of our application by using a predefined template. |
There was a problem hiding this comment.
This doesn't clearly describe what the parser does. Should make clear that the shell is extrapolated from a fully dynamic prerendered page (though the words "dynamic" and "prerendered" aren't necessarily the most meaningful words to drive the point home). The sentence as it reads now sounds like it's describing the pre-renderer instead of the parser.
4d680e2 to
d1fcf53Compare
No description provided.