Skip to content
This repository was archived by the owner on Apr 17, 2026. It is now read-only.

Fix macOS arch checks. - #493

Open
LeviticusMB wants to merge 1 commit into
angular:legacyfrom
Onslip:macos-gecko
Open

Fix macOS arch checks.#493
LeviticusMB wants to merge 1 commit into
angular:legacyfrom
Onslip:macos-gecko

Conversation

@LeviticusMB

Copy link
Copy Markdown

Code checked if filename matches macos. geckodriver-v0.29.1-macos-aarch64.tar.gz matches, even though geckodriver-v0.29.1-macos.tar.gz would be the correct archive to download.

@google-cla

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@LeviticusMB

Copy link
Copy Markdown
Author

@googlebot I signed it!

@google-cla

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@cnishina

Copy link
Copy Markdown
Contributor

I'll try to review this tomorrow.

@LeviticusMB

Copy link
Copy Markdown
Author

... and? 😁

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@LeviticusMB@googlebot@cnishina