es6-promise overwrites zone.js

[josephliccini]

I am not sure exactly which library is exactly responsible for the issue, but if one looks at this line:

https://github.com/stefanpenner/es6-promise/blob/a5838bd94a76e31ad80ac1685bcd0dbc3d8ce963/dist/es6-promise.js#L1133-L1144

One can see that they are expecting
Object.prototype.toString.call(window.Promise.resolve()) to be [object Promise], but zone.js gives [object Object]

So, I am wondering, should es6-promise (coming from another widget hosted on our page served over their CDN) look for [object Object], or should zone.js have [object Promise] for this toString()

[josephliccini]

This seems to work, though not clean:

var oldToString = Object.prototype.toString;
Object.prototype.toString = function () {
    if (this instanceof Promise) {
        return '[object Promise]';
    }
    return oldToString.call(this);
};

Maybe this could be added to zone.js so other polyfills won't overwrite?

[josephliccini]

Or perhaps Zone.js could make window.Promise a setter function, and anytime it is set, Zone.js wraps with ZoneAwarePromise? So then if any library were to set window.Promise, it could reject it, wrap it, or at least warn? Just brainstorming here

[JiaLiPassion]

@josephliccini , it seems duplicate with #499, I will check the behavior later.

[josephliccini]

This one seems fixed, and works great for es6-promise! Thanks!

There is one issue I am seeing, but it's not affecting me but may be good for you to know.

I did a test to see what would happen with core-js Promise.

My code has this now:

import 'zone.js';
import 'core-js/es6/promise';

And before bootstrap I get this error:

Uncaught TypeError: NativePromise.resolve is not a function
    at Object.setNativePromise (zone.js:634)
    at desc.set (zone.js:1028)
    at webpackJsonp.../../../../node_modules/core-js/modules/_redefine.js.module.exports (_redefine.js:19)
    at $export (_export.js:27)
    at Object.../../../../node_modules/core-js/modules/es6.promise.js (es6.promise.js:230)
    at __webpack_require__ (?mockauth=2:61)
    at Object.../../../../node_modules/core-js/es6/promise.js (promise.js:4)
    at __webpack_require__ (?mockauth=2:61)
    at Object../vendor.ts (zone.js:3026)
    at __webpack_require__ (?mockauth=2:61)

[JiaLiPassion]

@josephliccini , thanks for the information, I will check this error.

[josephliccini]

@JiaLiPassion thanks I am excited to try in next release :)

[kflorian]

Our app is not working on IE11 due to this issue, using version 0.8.18.
Waiting desperately for a fixed version!

[goyalvarun601]

any update on this?

[JiaLiPassion]

@goyalvarun601 , this one have been merged, please wait for the next release.

[goyalvarun601]

thanks @JiaLiPassion , when is the next release?

[JiaLiPassion]

@goyalvarun601 , I am not sure, please wait for a while.