Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

fix(test): karma-dist should test bundle under dist - #1049

Merged
mhevery merged 1 commit into
angular:masterfrom
JiaLiPassion:ci
Jun 18, 2018
Merged

fix(test): karma-dist should test bundle under dist#1049
mhevery merged 1 commit into
angular:masterfrom
JiaLiPassion:ci

Conversation

@JiaLiPassion

@JiaLiPassionJiaLiPassion commented Mar 16, 2018

Copy link
Copy Markdown
Collaborator

update karma-dist.conf.js

current karma-dist.conf.js will load bundles under dist and the purpose is to test those built bundles instead of the dev version which under build folder.
so in karma-dist.conf.js, we will load

config.files.push('dist/zone.js');config.files.push('dist/async-test.js');
...

But in current test cases will load some of the lib directly from build folder, for example in async-test.spec.ts, in current version, it will load

import'../../lib/zone-spec/async-test';

so the test case in fact will not test the bundle under dist but build.


in this PR, I load all needed bundles in karma-dist.conf.js and remove all directly import from test specs. And also modify the test entry classes to make sure currently test cases will be ok for both build test and dist test.

  • in dev mode, test bundles under build.
  • in dist mode, test bundles under dist.

Also disable ios 8.4 test because saucelabs seems not stable

change default karma browser to Chrome.

change rollup globals.

add ios 11, edge 15, android 7.1 to ci test.

@mhevery

Copy link
Copy Markdown
Contributor

can you resolve these?

@mhevery
mhevery merged commit 0720d79 into angular:masterJun 18, 2018
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@JiaLiPassion@mhevery@googlebot