Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Feb 26, 2024. It is now read-only.
fix(test): karma-dist should test bundle under dist - #1049
Merged
Conversation
JiaLiPassionforce-pushed
the
ci
branch
2 times, most recently
from
March 16, 2018 15:34
fed65b1 to
6b20a8cComparemhevery
commented
Mar 30, 2018
Contributor
can you resolve these? |
JiaLiPassionforce-pushed
the
ci
branch
4 times, most recently
from
March 30, 2018 21:46
7c6e644 to
c3bf79eCompareJiaLiPassionforce-pushed
the
ci
branch
9 times, most recently
from
April 13, 2018 09:01
2b6dedf to
1550209Comparemhevery
approved these changes
Jun 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update karma-dist.conf.js
current
karma-dist.conf.jswill load bundles underdistand the purpose is to test those built bundles instead of the dev version which underbuildfolder.so in
karma-dist.conf.js, we will loadBut in current test cases will load some of the lib directly from
buildfolder, for example inasync-test.spec.ts, in current version, it will loadso the test case in fact will not test the bundle under
distbutbuild.in this PR, I load all needed bundles in
karma-dist.conf.jsand remove all directly import from test specs. And also modify the test entry classes to make sure currently test cases will be ok for bothbuildtest anddisttest.build.dist.Also disable ios 8.4 test because saucelabs seems not stable
change default karma browser to Chrome.
change rollup globals.
add ios 11, edge 15, android 7.1 to ci test.