Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Feb 26, 2024. It is now read-only.
fix(core): fix #1108, window.onerror should have (message, source, ....) signiture - #1109
Merged
Conversation
JiaLiPassionforce-pushed
the
onerror
branch
6 times, most recently
from
July 5, 2018 16:45
ced117e to
9529ddfCompareJiaLiPassionforce-pushed
the
onerror
branch
5 times, most recently
from
July 6, 2018 12:01
f85d2fa to
681bbc4Compare…rce, lineno, colno, error) signiture
mhevery
approved these changes
Jul 17, 2018
pamo
commented
Oct 31, 2018
Re-iterating what others have already asked: any ideas around when this will be released? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix#1108,
Based on the document here, https://developer.mozilla.org/en-US/docs/Web/API/GlobalEventHandlers/onerror#window.onerror
The signature of
window.onerrorshould beAnd
window.addEventListener('error', listener)should beSo we must handle the
onerrorspecial case.