Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

fix(core): fix #1108, window.onerror should have (message, source, ....) signiture - #1109

Merged
mhevery merged 1 commit into
angular:masterfrom
JiaLiPassion:onerror
Jul 17, 2018
Merged

fix(core): fix #1108, window.onerror should have (message, source, ....) signiture#1109
mhevery merged 1 commit into
angular:masterfrom
JiaLiPassion:onerror

Conversation

@JiaLiPassion

Copy link
Copy Markdown
Collaborator

Fix#1108,
Based on the document here, https://developer.mozilla.org/en-US/docs/Web/API/GlobalEventHandlers/onerror#window.onerror

The signature of window.onerror should be

window.onerror=function(message,source,lineno,colno,error){ ... }

And window.addEventListener('error', listener) should be

window.addEventListener('error',function(event){ ... })

So we must handle the onerror special case.

@JiaLiPassion
JiaLiPassionforce-pushed the onerror branch 6 times, most recently from ced117e to 9529ddfCompareJuly 5, 2018 16:45
@JiaLiPassionJiaLiPassion changed the title fix(core): fix #1108, window.onerror should have (message, source, ....) signitureWIP(core): fix #1108, window.onerror should have (message, source, ....) signitureJul 5, 2018
@JiaLiPassion
JiaLiPassionforce-pushed the onerror branch 5 times, most recently from f85d2fa to 681bbc4CompareJuly 6, 2018 12:01
@JiaLiPassionJiaLiPassion changed the title WIP(core): fix #1108, window.onerror should have (message, source, ....) signiturefix(core): fix #1108, window.onerror should have (message, source, ....) signitureJul 6, 2018
@mhevery
mhevery merged commit 49e0548 into angular:masterJul 17, 2018
@pamo

pamo commented Oct 31, 2018

Copy link
Copy Markdown

Re-iterating what others have already asked: any ideas around when this will be released?

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@JiaLiPassion@pamo@mhevery@googlebot