Uh oh!
There was an error while loading. Please reload this page.
feat(build): Upgrade to TypeScript 2.9 and rxjs6 - #1122
Conversation
This includes a migration to TS2.9, and a migration to RxJS 6 (which is required for TS2.9 support).
googlebot
commented
Jul 30, 2018
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
1 similar comment
googlebot
commented
Jul 30, 2018
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
mprobst
commented
Jul 30, 2018
@googlebot I herewith confirm that I am OK with my commits being contributed to this project. |
sssalib42
commented
Aug 24, 2018
@JiaLiPassion , and @mprobst@googlebot can we please complete this PR! It's literally that last thing stopping me from completing my last step in RxJS 6 process which is removing rxjs-compat.... Come on now! The updated was like back in April... |
JiaLiPassion
commented
Aug 29, 2018
@sssalib42, I am not sure the release schedule, please use the following branch as temp test solution. |
arusak
commented
Aug 31, 2018
Would somebody please satisfy this horny bot? |
JiaLiPassion
commented
Aug 31, 2018
@arusak, the |
Sorry JiaLiPassion, my team isn't comfortable with using a non-production copy of the code. Author consent!? How can we fix the cal/google error requiring an author consent verification? |
sssalib42
commented
Sep 6, 2018
@IgorMinar@mhevery@robwormald@StephenFluin@alxhub@benlesh Angular 7 is coming out in the next few weeks and we still can't completely upgrade to Angular 6! |
googlebot
commented
Sep 6, 2018
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) |
1 similar comment
googlebot
commented
Sep 6, 2018
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) |
sssalib42
commented
Sep 7, 2018
Thank you @mhevery!!! I'm so happy to have come so close from interacting with the founder, and the man who started it all. The Father of Angular :):):) |
This includes a migration to TS2.9, and a migration to RxJS 6 (which is required for TS2.9 support).
fix#1091.
And this PR is based on #1104, thanks for @mprobst's great help!