fix(node): fix #1164, don't patch uncaughtException to prevent endless loop.

.travis.yml

@@ -3,7 +3,7 @@ sudo: false
 dist: trusty
 cache: yarn
 node_js:
- - 8
+ - 10
 env:
  global:
  - BROWSER_PROVIDER_READY_FILE=/tmp/sauce-connect-ready

lib/common/events.ts

@@ -10,7 +10,7 @@
  * @suppress {missingRequire}
  */
 
-import {ADD_EVENT_LISTENER_STR, attachOriginToPatched, FALSE_STR, ObjectGetPrototypeOf, REMOVE_EVENT_LISTENER_STR, TRUE_STR, ZONE_SYMBOL_PREFIX, zoneSymbol} from './utils';
+import {ADD_EVENT_LISTENER_STR, attachOriginToPatched, FALSE_STR, isNode, ObjectGetPrototypeOf, REMOVE_EVENT_LISTENER_STR, TRUE_STR, ZONE_SYMBOL_PREFIX, zoneSymbol} from './utils';
 
 /** @internal **/
 interface EventTaskData extends TaskData {
@@ -330,10 +330,15 @@ export function patchEventTarget(
  returnTarget = false, prepend = false) {
  return function() {
  const target = this || _global;
+ const eventName = arguments[0];
  let delegate = arguments[1];
  if (!delegate) {
  return nativeListener.apply(this, arguments);
  }
+ if (isNode && eventName === 'uncaughtException') {
+ // don't patch uncaughtException of nodejs to prevent endless loop
+ return nativeListener.apply(this, arguments);
+ }
 
  // don't create the bind delegate function for handleEvent
  // case here to improve addEventListener performance
@@ -350,7 +355,6 @@ export function patchEventTarget(
  return;
  }
 
- const eventName = arguments[0];
  const options = arguments[2];
 
  if (blackListedEvents) {

test/node/events.spec.ts

@@ -183,4 +183,10 @@ describe('nodejs EventEmitter', () => {
  expect(emitter.listeners('removeListener').length).toBe(0);
  });
  });
-});
+ it('should not enter endless loop when register uncaughtException to process', () => {
+ require('domain');
+ zoneA.run(() => {
+ process.on('uncaughtException', function() {});
+ });
+ });
+});