Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

ci(SauceLabs): refresh browsers list - #716

Merged
mhevery merged 5 commits into
angular:masterfrom
marclaval:updateSL
Apr 10, 2017
Merged

ci(SauceLabs): refresh browsers list#716
mhevery merged 5 commits into
angular:masterfrom
marclaval:updateSL

Conversation

@marclaval

Copy link
Copy Markdown
Contributor

The list should be old browsers supported by Angular.

@marclaval
marclaval force-pushed the updateSL branch 5 times, most recently from dc63618 to 1ec38e4 Compare April 3, 2017 15:26
@JiaLiPassion

Copy link
Copy Markdown
Collaborator

@Mlaval , I will make all those test pass on the added browsers after my other PR merged.

@marclaval
marclaval force-pushed the updateSL branch 2 times, most recently from fa57b71 to 5db3bba Compare April 4, 2017 09:56
@marclaval

Copy link
Copy Markdown
Contributor Author

@JiaLiPassion I included 2 small fixes to make the CI to pass.
2 things remain:

@JiaLiPassion

JiaLiPassion commented Apr 4, 2017

Copy link
Copy Markdown
Collaborator

@Mlaval, got it, I will modify my PR later and #718 is fixed by #726

@googlebot

Copy link
Copy Markdown

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

1 similar comment
@googlebot

Copy link
Copy Markdown

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@mhevery
mhevery merged commit 2de7ef0 into angular:master Apr 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants