This repository was archived by the owner on Feb 26, 2024. It is now read-only.
fix: make getter safe when patching a property - #721
Closed
marclaval wants to merge 1 commit into
Closed
Conversation
Collaborator
Contributor
Author
|
For information, I can only see this in Safari 10.0 and iOS 10.2 browser. |
Collaborator
|
@Mlaval, got it, I will try to reproduce it. |
Collaborator
|
@Mlaval , I have made a PR #723 to fix this one, and I tried with angular travis build, it should be ok now, https://travis-ci.org/angular/angular/jobs/218714508, so I think you may close this one. |
Contributor
Author
|
Closing in favor of #723 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure about how to test this case, but it is happening in Safari 10.0 and iOS 10.2 when running the Angular main test campaign: