Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

fix(promise): fix #850, check Promise.then writable - #851

Merged
mhevery merged 1 commit into
angular:masterfrom
JiaLiPassion:issue-850
Jul 27, 2017
Merged

fix(promise): fix #850, check Promise.then writable#851
mhevery merged 1 commit into
angular:masterfrom
JiaLiPassion:issue-850

Conversation

@JiaLiPassion

Copy link
Copy Markdown
Collaborator

in meteor environment, Promise.prototype.then was defined as

{writable: false,configurable: true}

so we can't patch it, we have to check if it is the case, we should change the writable to true.

@mhevery
mhevery merged commit 6e44cab into angular:masterJul 27, 2017
@JiaLiPassion
JiaLiPassion deleted the issue-850 branch August 10, 2017 02:52
@ardatanardatan mentioned this pull request Nov 1, 2017
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@JiaLiPassion@mhevery@googlebot