added new units to the TemperatureChangeRate quantity - #1433
Conversation
| "FromUnitToBaseFunc": "({x} / 60) - 273.15", | ||
| "FromBaseToUnitFunc": "({x} + 273.15) * 60", | ||
| "FromUnitToBaseFunc": "{x} / 60", | ||
| "FromBaseToUnitFunc": "{x} * 60", |
There was a problem hiding this comment.
Good catch, I missed this when I last reviewed this by checking google, which gives the wrong answer:
https://www.google.com/search?q=DegreesKelvinPerMinute+In+1+DegreeCelsiusPerSecond&rlz=1C1ONGR_enNO1008NO1008&oq=DegreesKelvinPerMinute+In+1+DegreeCelsiusPerSecond&gs_lcrp=EgZjaHJvbWUqBggAEEUYOzIGCAAQRRg70gEINTE2NmowajeoAgCwAgA&sourceid=chrome&ie=UTF-8
It totally makes sense for kelvin and celsius rate of change to be equal.
There was a problem hiding this comment.
@angularsen thanks for merging my PR. Do you know (roughly) when you will release a new Nuget package?
There was a problem hiding this comment.
Thanks for the reminder, I got busy and forgot it (again). Maybe it is my age 🤔
There was a problem hiding this comment.
ahhh thank you for catching my mistake, as well as the links explaining the correct calculation!!
angularsen
commented
Dec 9, 2024
Thanks! Nuget should be out shortly. |
David-HH-Dev
commented
Dec 11, 2024
Thank you @angularsen |
angularsen
commented
Dec 15, 2024
@David-HH-Dev Thanks for checking in, turns out there was a build error due to some new vulnerability in a Nuget.Protocol nuget package (meta!) I just pushed a fix, let's see if the nuget gets deployed in the next 30 minutes or so. |
angularsen
commented
Dec 15, 2024
Another brand new compile error 🙄 |
angularsen
commented
Dec 29, 2024
Merged into V6 branch, nuget should be out shortly. |
added the following units to TemperatureChangeRate:
DegreeFahrenheitPerMinute
DegreeFahrenheitPerSecond
DegreeKelvinPerSecond
DegreeCelsiusPerHour
DegreeKelvinPerHour
DegreeFahrenheitPerHour
After reviewing the unit tests I came to the conclusion that the recently added (#1429) unit DegreeKelvinPerMinute had a wrong conversion.
I checked that for example here:
https://www.unitsconverters.com/en/Rate-Of-Temperature-Change-Conversions/Measurement-1189
and also here:
https://www.quora.com/Why-is-32-not-used-when-converting-per-degree-Celsius-C-1-to-per-degree-Fahrenheit-F-1