💥Change UnitAbbreviationsCache ctor to not load defaults - #1476
Merged
Conversation
Ref #1200 - Remove UnitAbbreviationsCache.CreateEmpty() - Change default ctor to NOT load default unit abbreviations, use `CreateDefault()` instead - Fix 2 broken test cases
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## release/v6 #1476 +/- ##
==========================================
Coverage 86% 86% ==========================================
Files 298 298 Lines 30516 30515 -1 ==========================================
+ Hits 26404 26405 +1 + Misses 4112 4110 -2 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #1200
CreateDefault()instead