Skip to content

Remove SupportsSIUnitSystem => true property overrides - #1537

Merged
angularsen merged 4 commits into
angularsen:masterfrom
lipchev:master
Apr 11, 2025
Merged

Remove SupportsSIUnitSystem => true property overrides#1537
angularsen merged 4 commits into
angularsen:masterfrom
lipchev:master

Conversation

@lipchev

Copy link
Copy Markdown
Collaborator

fixes#1463

@lipchev

Copy link
Copy Markdown
CollaboratorAuthor

Duplicate of #1534 which got deleted when release/v6 went away..

As expected, there are only the

ElectricApparentEnergy
ElectricReactiveEnergy
FuelEfficiency

which override this property (and also [Skip] the corresponding tests). The only other tests that are skipped are for the BaseUnit_HasSIBase (as noted in the linked issue).

@angularsen
angularsen merged commit 46663ea into angularsen:masterApr 11, 2025
@angularsenangularsen changed the title Removing the SupportsSIUnitSystem => true property overridesRemove SupportsSIUnitSystem => true property overrides (#1537)Apr 11, 2025
@angularsenangularsen changed the title Remove SupportsSIUnitSystem => true property overrides (#1537)Remove SupportsSIUnitSystem => true property overridesApr 11, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The SupportsSIUnitSystem property should no be needed

2 participants

@lipchev@angularsen