Skip to content

refactor: Remove obsolete FromQuantityInfo method - #1574

Merged
angularsen merged 1 commit into
masterfrom
agl/rem-obsolete
Jul 25, 2025
Merged

refactor: Remove obsolete FromQuantityInfo method#1574
angularsen merged 1 commit into
masterfrom
agl/rem-obsolete

Conversation

@angularsen

Copy link
Copy Markdown
Owner

Fixup of #1555

@lipchev

Copy link
Copy Markdown
Collaborator

This was just for backwards compatibility, I don't think this method was [Obsolete] in v5- so instead of breaking the build, i figured we'd issue a deprecation warning. But if you think we don't need it, I'm perfectly fine with it..

@codecov

codecovBot commented Jul 25, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93%. Comparing base (5131d24) to head (3ff3fda).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #1574 +/- ##
======================================
- Coverage 93% 93% -1% 
======================================
Files 311 311 Lines 28781 28780 -1 ======================================
- Hits 26864 26863 -1 
Misses 1917 1917 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@angularsen

Copy link
Copy Markdown
OwnerAuthor

Let's remove stuff now that we have the chance in v6, I'd rather add it back if there was something we missed.

@angularsen
angularsen merged commit 77ada0e into masterJul 25, 2025
3 checks passed
@angularsen
angularsen deleted the agl/rem-obsolete branch July 25, 2025 18:08
@angularsen

Copy link
Copy Markdown
OwnerAuthor

Obsoleted in v5: #1577

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@angularsen@lipchev