Skip to content

Use latest UnitsNet NuGet in samples - #1712

Merged
angularsen merged 1 commit into
masterfrom
agl-codex/remove-sample-version-overrides
Jul 30, 2026
Merged

Use latest UnitsNet NuGet in samples#1712
angularsen merged 1 commit into
masterfrom
agl-codex/remove-sample-version-overrides

Conversation

@angularsen

Copy link
Copy Markdown
Owner

Motivation

PR #1544 left the samples with a development-only package override for normal builds, while only the Official configuration used the published NuGet package. That override also pointed to the accidental pre103 version.

The samples should always exercise the package users install.

Changes

  • Reference UnitsNet 6.0.0-pre021 centrally for all samples.
  • Remove the configuration-specific package overrides.
  • Update the custom quantity sample to implement ILinearQuantity, matching the current v6 aggregation APIs.

Validation

  • Restored the sample solution with an empty-cache package resolution.
  • Built Samples/Samples.slnx in Release successfully.
  • Verified that no development VersionOverride or conditional UnitsNet package references remain.
  • Ran git diff --check.

@angularsen
angularsen marked this pull request as ready for review July 30, 2026 22:43
@angularsen
angularsenforce-pushed the agl-codex/remove-sample-version-overrides branch from 9ceac28 to 6bf0e59CompareJuly 30, 2026 22:44
@angularsen
angularsen enabled auto-merge (squash) July 30, 2026 22:45
@codecov

codecovBot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98%. Comparing base (42205dc) to head (6bf0e59).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #1712 +/- ##
========================================
- Coverage 98% 98% -1% 
========================================
Files 512 514 +2 Lines 22883 24037 +1154 ========================================
+ Hits 22611 23644 +1033 - Misses 272 393 +121 
FlagCoverage Δ
net4897% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@angularsen
angularsen merged commit 610229e into masterJul 30, 2026
6 checks passed
@angularsen
angularsen deleted the agl-codex/remove-sample-version-overrides branch July 30, 2026 23:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@angularsen