Dynamic unit conversions by tmilnthorp · Pull Request #588 · angularsen/UnitsNet

tmilnthorp · 2019-01-25T16:58:37Z

UnitConverter: Change from hard coded switch statement to lookup of conversion functions
Allow consumers to add their own conversion functions between their own quantity types

Idea for #478. I'll add more commentary there.

Allowing custom unit conversion functions to be specified

Registering default base->unit and unit->base conversion functions in UnitConverter. Adding test for custom direct conversions

tmilnthorp · 2019-01-25T17:01:57Z

This isn't completely fleshed out yet. Just to show an idea, so don't merge it yet.

Comments in #478

Whitespace consistency

Add some overloads and allowing source/target quantities to be different

angularsen

Interesting approach, it definitely unlocks the ability to add explicit unit-to-unit conversions even across quantities. I'll comment further in the issue #478 instead.

Inline initialization and style update for field

PR feedback updates

angularsen

New changes looks good, but still need to digest how and why this will be used. Continuing discussion in issue.

angularsen · 2019-01-30T20:35:25Z

Adding a summary from prior discussion here:

As for direct conversions, I think that sounds like a good idea regardless:

A single piece of code to handle all conversions, generically
Route existing unit-base and base-unit conversions through it
Ability to add higher-precision direct conversions
Ability to add cross-quantity conversions
Ability to plug in 3rd party conversions of 3rd party unit enums
Compatible with the new dynamic Quantity in Improve working dynamically with units and quantities #576 for converting dynamically

Regen WRC

angularsen · 2019-02-23T13:31:18Z

Re-reading this now.

…ersions

It was looked up and wrapped N times

They became a bit unwieldy. Move fields to top of class.

Since this is the most commonly used call path by far, it made sense to handle this case separately. The advantage is that the callback quantity is strongly typed.

angularsen

I think this is looking pretty good. I just took the liberty of adding some changes directly to the branch, please review them and see what you think.

https://github.com/angularsen/UnitsNet/pull/588/commits

angularsen · 2019-02-26T01:31:29Z

When this is merged, this wiki should be updated on the new capability to add unit conversions:
https://github.com/angularsen/UnitsNet/wiki/Extending-with-Custom-Units

tmilnthorp · 2019-03-01T04:09:24Z

More work to do here (including doc obviously after warnings-as-errors). Just merging to keep up to date.

Header update

…m quantity conversions

angularsen · 2019-04-22T09:58:20Z

@tmilnthorp I took this for spin locally and added some improvements. I think this is ready to merge now, but waiting for you to check out the latest changes.

I was specifically interested in seeing how we can improve support for third party quantities and units and added some test cases for that. It works pretty well by now, you can parse units, parse quantities and convert between quantities using only custom types. We still enforce the requirement of implementing IQuantity, which I did find awkward when adding an example HowMuch quantity since that interface is pretty bloated and most of it is not used for simple conversions and parsing.

I think there is definitely an opportunity to support simple POCO classes and structs without them having to implement IQuantity, but I didn't want to clutter this PR with that.

If you have time, I'd also love to merge #656 .

angularsen

Looks good to me, waiting for you to review my latest improvements.

angularsen · 2019-05-01T23:15:57Z

This needs to port the powershell changes to the new C# codegen scripts.

Update: Fixed.

The only difference is fixing the header of a file.

angularsen · 2019-07-17T20:55:47Z

@tmilnthorp I think this one is good to go. Two months ago I made some changes to it and I'd like you to look over them whenever you find the time so we can get this puppy merged :)

tmilnthorp · 2019-07-18T13:35:46Z

Looks good to me!

angularsen · 2019-07-18T20:56:34Z

Sweet!

angularsen · 2019-07-18T21:04:55Z

Release UnitsNet/4.30.0 · angularsen/UnitsNet

tmilnthorp added 2 commits January 24, 2019 11:32

16a4854
Allowing custom unit conversion functions to be specified

fa2a2c1
Registering default base->unit and unit->base conversion functions in UnitConverter. Adding test for custom direct conversions

tmilnthorp mentioned this pull request Jan 25, 2019
Suggestion: define conversions as rational values #478
Closed

tmilnthorp added 2 commits January 25, 2019 13:43

a9beb6e
Whitespace consistency

b4a4277
Add some overloads and allowing source/target quantities to be different

angularsen reviewed Jan 26, 2019
View reviewed changes

Comment threadUnitsNet/UnitConverter.cs Outdated
Comment threadUnitsNet/GeneratedCode/Quantities/ElectricInductance.NetFramework.g.cs Outdated

tmilnthorp added 3 commits January 28, 2019 09:17

f552e8b
Inline initialization and style update for field

de56c47
PR feedback updates

Merge branch 'master' into UnitConversions
c5b039a

angularsen reviewed Jan 28, 2019
View reviewed changes

Comment thread...t.WindowsRuntimeComponent/GeneratedCode/Quantities/Acceleration.WindowsRuntimeComponent.g.cs Outdated
Comment threadUnitsNet/GeneratedCode/UnitConverter.g.cs Outdated
Comment threadUnitsNet/UnitConverter.cs Outdated

tmilnthorp added this to the ln3@Dash milestone Feb 4, 2019

angularsen mentioned this pull request Feb 7, 2019
Add VolumePerLength #604
Merged

angularsen removed this from the ln3@Dash milestone Feb 13, 2019

tmilnthorp added 2 commits February 19, 2019 11:47

Merge branch 'master' into UnitConversions
66c1eab

ad313fa
Regen WRC

angularsen added 7 commits February 23, 2019 14:33

Merge remote-tracking branch 'origin/master' into tmilnthorp-UnitConv…
c9e6f46
…ersions

Use IQuantity.Value in test case
beedad4

Rename typeparams, remove empty ctor
bc3a808

Micro optimization of lookup of IQuantity type
619de36
It was looked up and wrapped N times

UnitConverter: Move static field initialization to static ctor
6a2befd
They became a bit unwieldy. Move fields to top of class.

Add typed conversion function for same quantity conversion functions
1dc6c27
Since this is the most commonly used call path by far, it made sense to handle this case separately. The advantage is that the callback quantity is strongly typed.

Use typed conversions in RegisterDefaultConversions
b27f3d5

angularsen reviewed Feb 23, 2019
View reviewed changes

Comment threadUnitsNet.Tests/UnitConverterTest.cs Outdated
Comment threadUnitsNet/GeneratedCode/UnitConverter.g.cs Outdated
Comment threadUnitsNet/UnitConverter.cs Outdated

Merge branch 'master' into UnitConversions
9f74054

tmilnthorp changed the title ~~Unit conversions~~Unit conversions (WIP)Mar 1, 2019

5c49f66
Header update

tmilnthorp mentioned this pull request Mar 1, 2019
Rename AsBaseNumericType to GetValueAs #619
Merged

This was referenced Apr 18, 2019
New unit request: Pitch for screw threads #654
Closed
Conversion error from Micrometer to Nanometer in Length class #653
Closed

angularsen added 7 commits April 22, 2019 09:17

Merge remote-tracking branch 'origin/master' into UnitConversions
050dc49

Add xmldoc and minor renaming
8cc352e

Add test cases for Type parameters
16dca81

QuantityParser: Make field readonly
995be8c

Merge remote-tracking branch 'origin/master' into HEAD
e1b1176

UnitParser: Add test parsing HowMuch custom unit
b60a940

UnitConverter: Echo quantity when converting to same unit, test custo…
605386d
…m quantity conversions

angularsen approved these changes Apr 22, 2019
View reviewed changes

angularsen changed the title ~~Unit conversions (WIP)~~Dynamic unit conversionsApr 22, 2019

angularsen added 2 commits May 2, 2019 01:22

Merge remote-tracking branch 'origin/master' into UnitConversions
3aca89c

Port codegen scripts to C#
dff33f0
The only difference is fixing the header of a file.

angularsen mentioned this pull request May 8, 2019
Generic Parameters For Measurement Quantities #666
Open

angularsen added 2 commits July 17, 2019 22:53

Merge remote-tracking branch 'origin/master' into UnitConversions
04f1c2f

Regen code
53c43cf

angularsen mentioned this pull request Jul 18, 2019
Adding Astronomical units #679
Closed

angularsen merged commit 25ff826 into angularsen:masterJul 18, 2019

angularsen mentioned this pull request Jul 19, 2019
Added units for Astronomy. #680
Merged

angularsen mentioned this pull request Sep 18, 2021
Overload * operator for BitRate and Duration #968
Closed

Conversation

tmilnthorp commented Jan 25, 2019• edited by angularsen Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tmilnthorp commented Jan 25, 2019

Uh oh!

angularsen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

angularsen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

angularsen commented Jan 30, 2019

Uh oh!

angularsen commented Feb 23, 2019

Uh oh!

angularsen left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

angularsen commented Feb 26, 2019

Uh oh!

tmilnthorp commented Mar 1, 2019

Uh oh!

angularsen commented Apr 22, 2019

Uh oh!

angularsen left a comment

Choose a reason for hiding this comment

Uh oh!

angularsen commented May 1, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

angularsen commented Jul 17, 2019

Uh oh!

tmilnthorp commented Jul 18, 2019

Uh oh!

angularsen commented Jul 18, 2019

Uh oh!

angularsen commented Jul 18, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tmilnthorp commented Jan 25, 2019•
edited by angularsen
Loading

angularsen left a comment •
edited
Loading

angularsen commented May 1, 2019•
edited
Loading