Add benchmarks for UnitSystem methods - #708
Conversation
Added benchmarks for UnitSystem methods (UnitSystem.SI)
lipchev
commented
Sep 26, 2019
BenchmarkDotNet=v0.11.5, OS=Windows 10.0.17763.737 (1809/October2018Update/Redstone5)
|
Codecov Report
@@ Coverage Diff @@## master #708 +/- ##
=======================================
Coverage 58.32% 58.32% =======================================
Files 166 166 Lines 37811 37811 =======================================
Hits 22055 22055 Misses 15756 15756Continue to review full report at Codecov.
|
angularsen
commented
Sep 27, 2019
Great, thanks! |
lipchev
commented
Sep 28, 2019
A quick note: the performance of the SI methods tested in this release are actually dependent on the quantity that is tested; here we test Length- which has ~ 30 UnitInfos (meter being in the middle), where for example VolumePerLength has only 3- thus it seems your result may vary (being slightly lower for most other quantities, on average):
|
angularsen
commented
Sep 29, 2019
Right. I don't recall the exact implementation for looking up the conversion functions from the top of my head, it has changed a few times lately, but I'm sure it can be improved. Maybe as simple as using a dictionary if we are not already using that. |
Added benchmarks for UnitSystem methods (UnitSystem.SI) in order to use as base line for comparison (I see there is a tool for that) with the modifications envisioned in #651