Add VolumePerLength yd3 / ft and ftUS - #734
Merged
Merged
Conversation
angularsen
approved these changes
Jan 11, 2020
angularsen
left a comment
Owner
There was a problem hiding this comment.
Looks good to me, but note that I did not verify the conversion constants as I could not find any conversion references.
| protected override double OilBarrelsPerFootInOneCubicMeterPerMeter => 1.917134088; | ||
| protected override double CubicYardsPerFootInOneCubicMeterPerMeter => 0.3986633487670267521605; |
There was a problem hiding this comment.
I was not able to verify these as I could not find any references, but I trust you checked it.
ContributorAuthor
There was a problem hiding this comment.
A quick check would be
1 m² = 1.19599 yd²
1.19599 yd² * (1 yd / 3 ft) = 0.3986633 yd³ / ft
Codecov Report
@@ Coverage Diff @@## master #734 +/- ##
==========================================
+ Coverage 58.56% 58.58% +0.01%
==========================================
Files 171 171 Lines 38430 38448 +18 ==========================================
+ Hits 22507 22525 +18
Misses 15923 15923
Continue to review full report at Codecov.
|
gojanpaolo
commented
Jan 11, 2020
ContributorAuthor
Thank you! |
jonsuda pushed a commit
to wgvdn/UnitsNet
that referenced
this pull request
Jan 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Succeeds #733