Add units to RotationalStiffness, VolumePerLength, ForcePerLength - #776
Conversation
…itional prefixes to ForcePerLength.
angularsen
left a comment
There was a problem hiding this comment.
Verified all the conversions.
A couple suggestions to rename some units. Make sure to run generate-code.bat once more and you probably have to manually rename the properties in the test code.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #776 +/- ##
==========================================
+ Coverage 63.47% 63.82% +0.34%
==========================================
Files 278 278 Lines 41087 41477 +390 ==========================================
+ Hits 26081 26471 +390
Misses 15006 15006
Continue to review full report at Codecov.
|
ajphall
commented
Apr 5, 2020
Thanks for tidying up the tests..looks much better! I updated the unit naming in the Rotational Stiffness as suggested. I also updated the names of some of the other units in the same file to keep everything following a consistent convention. |
| { | ||
| "SingularName": "PoundForceFootPerDegrees", | ||
| "PluralName": "PoundForceFeetPerDegrees", | ||
| "SingularName": "PoundForceFootPerDegree", |
There was a problem hiding this comment.
Great initiative, however this would be a breaking change and not something we can do.
I propose reverting these and adding a comment in #563 to address it there.
| "XmlDoc": "Volume, typically of fluid, that a container can hold within a unit of length.", | ||
| "BaseDimensions": { | ||
| "L": 3 | ||
| "L": 2 |
angularsen
commented
Apr 5, 2020
Thanks a lot, a new nuget is on the way. |
ajphall
commented
Apr 5, 2020
Great, thanks a lot. I will make a note in the linked issue as requested. |
In addition to adding the additional units I also made a change in the VolumePerLength BaseDimensions to change it from L=3 to L=2. I'm not sure if I misunderstood something, but if its m^3 / m then I'm not sure how it can be L=3. Maybe you did this to avoid ambiguity with area? I checked in the original PR (#604) and cannot find any explanation why its like this.