Rename DecimalFraction units to Decimal - #880
Conversation
angularsen
commented
Dec 29, 2020
Related to #879 |
lipchev
commented
Dec 29, 2020
I'm not sure about this- the linked definition emphasizes the distinction between 1/2 (fraction) and 5/10 (decimal fraction). However what we're representing is the right hand side of the equation: e.g. 0.53 which is the decimalvalue representation of a fraction (i.e. using a decimal symbol). |
angularsen
commented
Dec 29, 2020
@lipchev Good point, some more googling and I believe decimal is the correct term?
|
angularsen
commented
Dec 29, 2020
Updated PR to use |
cfa4199 to
f752d12Comparef752d12 to
d2eeb3eCompareMarkCiliaVincenti
commented
Dec 30, 2020
The problem with Ratio.Decimal is that decimal is a type in C#, so it could create confusion. |
angularsen
commented
Jan 13, 2021
@MarkCiliaVincenti Right, but since its type is Are we happy with Decimal? Any other suggestions? |
lipchev
commented
Jan 13, 2021
I personally prefer
I also think that renaming this would have quite a visible effect on client code (having obsolete warnings popping all over the place), that it simply wouldn't be worth the effort.. |
angularsen
commented
Jan 13, 2021
@lipchev Ok, I had not considered the "visual representation" part. I guess it makes sense when reading the wiki section. https://en.wikipedia.org/wiki/Decimal#Decimal_fractions
I guess we could call it |


Decimal fraction is not a correct term.
Changes
Ratio.Decimalunit, markDecimalFractionunit as obsoleteRatioChangeRate.DecimalPerSecond, markDecimalFractionPerSecondunit as obsoleteChanging the base unit should not be a breaking change for most users and the conversion precision is exactly the same as before for all units.