Improvements in builds for .NET nanoFramework - #925
Conversation
dac1c7b to
7e577efCompare- Update PS1 to update version in nuspec files. - Rename Invoke-Build-NanoNugets to match PS version analysis used in AppVeyor. - Simplification of output messages reporting progress of .NET nanoFrameowrk projects processing. - Fix nuspec versions. - Remove whitespace in nuspec description. - Fix Directory.Build.props to point .NET nanoFramewok output directory to specific Artifacts sub-directory.
7e577ef to
ef15f50Compare| <projectUrl>https://github.com/angularsen/UnitsNet</projectUrl> | ||
| <requireLicenseAcceptance>false</requireLicenseAcceptance> | ||
| <description>Adds Frequency units for Units.NET on .NET nanoFramework. For .NET or .NET Core, use UnitsNet instead.</description> | ||
| <description>Adds Frequency units for Units.NET on .NET nanoFramework. For .NET or .NET Core, use UnitsNet instead.</description> |
There was a problem hiding this comment.
Is this character intentional? Why not a regular space? I pushed a commit removing it, but let me know if that was a mistake.
There was a problem hiding this comment.
Yes, that's a line break in XML.
It shows the description as:
Adds Frequency units for Units.NET on .NET nanoFramework.
For .NET or .NET Core, use UnitsNet instead.
Instead of:
Adds Frequency units for Units.NET on .NET nanoFramework. For .NET or .NET Core, use UnitsNet instead.
angularsen
left a comment
There was a problem hiding this comment.
Looks good to me. Merging it to see how it plays out on appveyor.
angularsen
commented
May 10, 2021
Checked the PR build, looks good to me.
|
josesimoes
commented
May 10, 2021
All right!! 👏🏻 😄 |
josesimoes
commented
May 10, 2021
@angularsen will you be uploading all the new nuget packages for nanoframework? Just checking... |
@josesimoes I'm currently waiting for master branch build to complete. I expect it to push 4.90.0 of the temperature nuget. |
angularsen
commented
May 10, 2021
It completed 10 minutes ago. Nuget is out. |
My bad! It's missing the others... I'll fix that ASAP. |
Changes addressing comments in #837 after merging and having the 1st full build on AppVeyor.