Skip to content

Add Duration.JulianYear - #978

Merged
angularsen merged 10 commits into
angularsen:masterfrom
ebfortin:develop/ebfortin
Nov 12, 2021
Merged

Add Duration.JulianYear#978
angularsen merged 10 commits into
angularsen:masterfrom
ebfortin:develop/ebfortin

Conversation

@ebfortin

@ebfortinebfortin commented Oct 24, 2021

Copy link
Copy Markdown
Contributor

Julian Year are used in astronomy and cosmology as a constant year length.

@ebfortin
ADD: Support for Julian Years in Duration unit.
0524280
Julian Year are used in astronomy and cosmology as a constant year length.
angularsen
angularsen requested changes Oct 25, 2021
View reviewed changes

@angularsenangularsen left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things

Comment threadUnitsNet.NumberExtensions/UnitsNet.NumberExtensions.csproj Outdated
Comment threadCommon/UnitDefinitions/Duration.json
angularsen
angularsen reviewed Oct 26, 2021
View reviewed changes
Comment threadUnitsNet.Tests/CustomCode/DurationTests.cs
@ebfortin
CHG: Removed support for net40 and net47.
fdebb3e
net47 is defacto supported through netstandard2.0.
@ebfortin
Revert "CHG: Removed support for net40 and net47."
bb902d8
This reverts commit fdebb3e.
angularsen
angularsen requested changes Nov 1, 2021
View reviewed changes

@angularsenangularsen left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another thing to revert, then this should be ready to go.

Comment threadUnitsNet.Serialization.JsonNet/UnitsNet.Serialization.JsonNet.csproj Outdated
@angularsen
angularsen changed the base branch from master to release/v5November 1, 2021 20:06
@angularsen
angularsen changed the base branch from release/v5 to masterNovember 1, 2021 20:07
@angularsenangularsen changed the title ADD: Support for Julian Years in Duration unit.Add Duration.JulianYearNov 12, 2021
@angularsen
angularsen merged commit 24e8e28 into angularsen:masterNov 12, 2021
@angularsen

angularsen commented Nov 12, 2021

Copy link
Copy Markdown
Owner

Release UnitsNet/4.103.0 · angularsen/UnitsNet

@angularsen

angularsen commented Nov 12, 2021

Copy link
Copy Markdown
Owner

Sorry for the delay. Nuget 4.103.0 is on the way.

@ebfortinebfortin mentioned this pull request Dec 11, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@angularsenangularsenAwaiting requested review from angularsen

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ebfortin@angularsen