MCP ENV variables are not injected?

[itschip]

I'm having some trouble with the mcp server. it doesn't seem like the env variable is injected? From what I saw in mcp-go/client, it just merges this list with the rest of os.Environ. Is this the correct format?

If this is a known bug, I''ll take a look at it and make a PR for it. Does seem like some work is begin on the llm agents on #35 however. Not sure if I should touch it before that.

 "mcpServers": {
 "github": {
 "command": "docker",
 "env": [
 "GITHUB_PERSONAL_ACCESS_TOKEN=<token>"
 ],
 "args": [
 "run",
 "-i",
 "--rm",
 "-e",
 "GITHUB_PERSONAL_ACCESS_TOKEN",
 "ghcr.io/github/github-mcp-server"
 ],
 "type": "stdio",
 "url": "",
 "headers": null
 }
 },

[itschip]

Ok, it does actually look like the environment variables are injected. The container just exits for some reason

[itschip]

Disregard :D I was under the impression that the mcp container would run at all times. It works fine :D

[ruchernchong]

Where is that snippet stored at?