Uh oh!
There was an error while loading. Please reload this page.
refactor(tui): theme switching & loading reactivity - #10472
Closed
nihil2501 wants to merge 1 commit into
Closed
Conversation
Contributor
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
nihil2501force-pushed
the
tui-theme-reactivity
branch
from
January 28, 2026 05:11
584e479 to
fcad986Comparenihil2501
commented
Jan 29, 2026
Author
Closed #9184 in favor of this in order to incrementally introduce an atomic foundational change before considering adding a feature on top of it. |
nihil2501force-pushed
the
tui-theme-reactivity
branch
from
January 29, 2026 06:00
fcad986 to
c975501Compare1 task
Author
cc @thdxr@rekram1-node this TUI theme reactivity remodel was developed while some of the Omarchy theme changes were being added, so this may be of interest / fresh in your minds. The short Fixes and Performance sections in the PR description discuss the concrete improvements. |
thdxrforce-pushed
the
dev
branch
4 times, most recently
from
January 30, 2026 14:37
f1ae801 to
08fa7f7Comparenihil2501force-pushed
the
tui-theme-reactivity
branch
4 times, most recently
from
February 11, 2026 03:24
f41140c to
ee5703fComparenihil2501force-pushed
the
tui-theme-reactivity
branch
2 times, most recently
from
February 17, 2026 01:25
bb86c29 to
1606248Comparenihil2501force-pushed
the
tui-theme-reactivity
branch
from
February 25, 2026 03:02
1606248 to
14712f5CompareContributor
Closing this pull request because it has had no updates for more than 60 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
systemcolors #6322Refactor
Remodels theme resolution reactivity with respect to this tuple:
This change also prepares for a feature, system-like custom themes, shown in this video:
Fixes
Performance
The theme context now readies 10x faster (30ms → 3ms) in by-far the most common case: using one of the default themes. The speedup is achieved by not waiting on resources irrelevant to the requested theme before marking it as ready.
Timed using this patch that calls
console.timeinsidecreateSimpleContext.After = 3.558ms
Before = 31.264ms
Implementation
createResourcescreateMemoreturning this tuple:createEffects