Uh oh!
There was an error while loading. Please reload this page.
fix(app) internal/external link handling - #10752
Conversation
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
adamdotdevin
commented
Jan 27, 2026
@alexyaroshuk can we not do something more similar to our previous approach by modifying the new markdown parser to add a class to markdown created anchors? I'm hesitant to take any other approach. |
alexyaroshuk
commented
Jan 27, 2026
right on, please check #10816 |
alexyaroshuk
commented
Jan 28, 2026
solved internally, closing |
Fixes#10613, #8361
What does this PR do?
fixes the external link handling issue that was reverted in #10697
The previous implementation broke internal app navigation (sessions, settings,
etc.) because it opened ALL links externally, regardless of whether they were
internal or external to the app.
Now properly distinguishes between internal and external links by comparing
origins.
Changes
How did you verify your code works?
Tested in a dev desktop build, dev web build, and in a release desktop build