fix(memory): resolve 6 memory leak issues in long-running sessions

[sgInnora]

Summary

This PR addresses 6 memory leak issues observed during long-running coding sessions (8+ hours). The fixes target critical areas where memory accumulates unboundedly.

Problem

During extended usage, opencode's memory footprint grows continuously, eventually causing performance degradation or crashes. Root causes identified:

1. AsyncQueue resolver accumulation - Pending resolvers never get cleaned up
2. Bash output string concatenation - Unbounded string growth in let output = ""
3. LSP diagnostics Map growth - No eviction policy for stale file diagnostics
4. Bus subscription leaks - Subscriptions not cleared on dispose
5. PTY buffer string concatenation - String-based buffer causes allocation pressure
6. Process exit cleanup - Instance resources not disposed on exit

Changes

File	Issue	Fix
util/queue.ts	Resolvers accumulate forever	Add close() and drain() methods, handle closed state
tool/bash.ts	output += chunk grows unbounded	Ring buffer with 10MB cap using Buffer[]
lsp/client.ts	Diagnostics Map grows infinitely	FIFO eviction at 5K files, clear() on shutdown
bus/index.ts	Subscriptions leak	subscriptions.clear() on dispose
pty/index.ts	String buffer allocation pressure	Buffer[] ring buffer replacing string concatenation
index.ts	Resources not cleaned on exit	Call Instance.disposeAll() in finally block

Technical Details

AsyncQueue (Critical)

// Before: Resolvers accumulate foreverprivateresolvers: ((value: T)=>void)[]=[]// After: Proper cleanup on closeclose(){this.closed=truefor(constresolveofthis.resolvers)resolve(undefined)this.resolvers.length=0}

Bash Tool (Critical)

// Before: Unbounded string growthletoutput=""output+=chunk.toString()// After: 10MB ring bufferconstMAX_OUTPUT_BYTES=10*1024*1024constoutputChunks: Buffer[]=[]while(outputSize>MAX_OUTPUT_BYTES&&outputChunks.length>1){constdropped=outputChunks.shift()!outputSize-=dropped.length}

LSP Client (High)

// Before: No limit on diagnosticsconstdiagnostics=newMap<string,Diagnostic[]>()// After: FIFO eviction at 5K filesconstMAX_DIAGNOSTICS_FILES=5000if(!exists&&diagnostics.size>=MAX_DIAGNOSTICS_FILES){constoldest=diagnostics.keys().next().valueif(oldest!==undefined)diagnostics.delete(oldest)}

Testing

• Tested on macOS with Apple Silicon (M3 Max)
• Monitored RSS over 8+ hour sessions
• Memory growth stabilized after applying fixes

Related

This is a resubmission based on the latest dev branch. Previous discussions may exist in earlier PRs.

---

Submitted by andy_feng (feng@innora.ai) from Innora Team

[github-actions]

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

1. Open an issue describing the bug/feature (if one doesn't exist)
2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

[github-actions]

The following comment was made by an LLM, it may be inaccurate:

Based on my search results, I found 2 potentially related PRs:

1. PR fix(opencode): resolve multiple memory leaks in long-running sessions #10914 - fix(opencode): resolve multiple memory leaks in long-running sessions

   • fix(opencode): resolve multiple memory leaks in long-running sessions #10914
   • Likely duplicate: This appears to be addressing the same core issue - memory leaks in long-running sessions. Given that PR fix(memory): resolve 6 memory leak issues in long-running sessions #12053 notes it's "a resubmission based on the latest dev branch," this could be the earlier version or a related attempt.

2. PR fix: add LRU eviction to LSP client file and diagnostics tracking #7050 - fix: add LRU eviction to LSP client file and diagnostics tracking

   • fix: add LRU eviction to LSP client file and diagnostics tracking #7050
   • Related: This specifically addresses LSP diagnostics memory issues with LRU eviction, which overlaps with issue feat: model config persistence #3 (LSP diagnostics Map growth) in the current PR.

3. PR fix(core): add dispose functions to prevent subscription memory leaks #7032 - fix(core): add dispose functions to prevent subscription memory leaks

   • fix(core): add dispose functions to prevent subscription memory leaks #7032
   • Related: Addresses subscription cleanup on dispose, which relates to issue feat: add configuration persistence for model selections #4 (Bus subscription leaks) in the current PR.

I recommend checking PR #10914 first, as it's most likely the previous attempt at fixing the same set of memory leak issues.