fix: use parentID matching instead of ID ordering for prompt loop exit and message rendering by MakonnenMak · Pull Request #14307 · anomalyco/opencode

MakonnenMak · 2026-02-19T16:44:34Z

Issue for this PR

Type of change

Bug fix
New feature
Refactor / code improvement
Documentation

What does this PR do?

Large # of line changes test additions.

When the client and server clocks are out of sync (e.g. browser on a local machine, server on a remote host), client-generated message IDs can sort after server-generated assistant IDs because IDs are timestamp-based. This caused two bugs:

Prompt loop never exits — the exit check compared user vs assistant message IDs by sort order. With clock skew, the user ID is always "newer" so the condition never triggers, causing 15+ loop iterations instead of 1.
Assistant messages not rendered — SessionTurn only scanned forward from the user message index to find assistant replies. With skewed IDs, the assistant sorts before the user message and was never found.

Fix: Both checks now use parentID matching instead of relying on ID/timestamp ordering:

Extracted shouldExitLoop() in prompt.ts — checks lastAssistant.parentID === lastUser.id regardless of ID sort order.
Extracted findAssistantMessages() in find-assistant-messages.tsx — scans forward first, then backward if nothing found, matching on parentID.
Removed debug console.log statements added during investigation.

I was running into this on coder.com remote environments where opencode web seemingly takes minutes to get a response back or just infinitely loops.

How did you verify your code works?

shouldExitLoop unit tests (8 cases): normal exit, clock skew exit, tool-calls, unknown, no assistant, no finish, parentID mismatch, no user
findAssistantMessages unit tests (8 cases): normal ordering, clock skew ordering, no assistant, multiple assistants, parentID mismatch, scan boundaries, invalid index
Full opencode test suite: 1110 pass, 0 fail
Full app test suite: 236 pass, 0 fail

Screenshots / recordings

N/A — no UI changes, logic-only fix.

Checklist

I have tested my changes locally
I have not included unrelated changes in this PR

github-actions · 2026-02-19T16:45:36Z

Thanks for updating your PR! It now meets our contributing guidelines. 👍

github-actions · 2026-02-19T16:45:50Z

The following comment was made by an LLM, it may be inaccurate:

Found one potentially related PR:

Related PR:

PR fix: server-generated message IDs to prevent client/server clock skew #11869 — "fix: server-generated message IDs to prevent client/server clock skew"
- fix: server-generated message IDs to prevent client/server clock skew #11869
- This appears to address the same underlying clock skew issue between client and server timestamps, though from a different angle (server-generated IDs vs. parentID matching logic)

The current PR (14307) takes a different approach to solving clock skew problems by using parentID matching instead of relying on timestamp-based ID ordering. PR #11869 may have attempted a fix at the ID generation level rather than the matching logic level. You may want to check if #11869 was merged or closed to understand the context.

alexyaroshuk · 2026-02-19T17:02:09Z

- if (input.assistantMessage.error) return "stop"
- return "continue"
+ const exitReason = needsCompaction ? "compact" : blocked ? "stop" : input.assistantMessage.error ? "stop" : "continue"
+ return exitReason as any


We should avoid using 'any' for typing. See Contributing guidelines

Fixed on latest commit thanks for flagging @alexyaroshuk . Unsure how to repro the windows e2e failure though, might it be flaky?

Seems like it was, new run with rebase passed 🙏🏾

MakonnenMak · 2026-02-20T18:24:11Z

There was a conflict with the base dev branch so I had to fix and rebase. Done ✅

alexyaroshuk · 2026-02-20T21:09:46Z

can't see any more issues, lgtm

MakonnenMak · 2026-02-21T16:46:05Z

@adamdotdevin wanted to bump for a review if you have some time 🙏🏾 currently blocking us from using opencode web on a coder.com remote dev env

MakonnenMak · 2026-02-24T18:48:20Z

@adamdotdevin bumping again, would be great to get this out

adamdotdevin · 2026-02-27T11:37:17Z

@rekram1-node want to get your eyes on this as well

…r prompt loop exit and message rendering

sjqwert · 2026-04-05T12:45:33Z

⚠️Blocking Beta Release

This PR cannot be merged into the beta branch due to: Merge failed

Please resolve this issue to include this PR in the next beta release.

MakonnenMak · 2026-04-06T15:08:23Z

@sjqwert on it

…t-loop-exit # Conflicts: # packages/opencode/src/session/prompt.ts

opencode-agent · 2026-04-16T09:42:25Z

⚠️Blocking Beta Release

This PR cannot be merged into the beta branch due to: Merge conflicts with dev branch

Please resolve this issue to include this PR in the next beta release.

opencode-agent · 2026-04-16T11:36:09Z

⚠️Blocking Beta Release

This PR cannot be merged into the beta branch due to: Merge conflicts with dev branch

Please resolve this issue to include this PR in the next beta release.

opencode-agent · 2026-04-17T02:21:32Z

⚠️Blocking Beta Release

This PR cannot be merged into the beta branch due to: Merge conflicts with dev branch

Please resolve this issue to include this PR in the next beta release.

opencode-agent · 2026-04-17T05:11:47Z

⚠️Blocking Beta Release

This PR cannot be merged into the beta branch due to: Merge conflicts with dev branch

Please resolve this issue to include this PR in the next beta release.

opencode-agent · 2026-04-17T11:30:42Z

⚠️Blocking Beta Release

This PR cannot be merged into the beta branch due to: Merge conflicts with dev branch

Please resolve this issue to include this PR in the next beta release.

opencode-agent · 2026-04-17T17:28:13Z

⚠️Blocking Beta Release

This PR cannot be merged into the beta branch due to: Merge conflicts with dev branch

Please resolve this issue to include this PR in the next beta release.

opencode-agent · 2026-04-17T18:32:55Z

⚠️Blocking Beta Release

This PR cannot be merged into the beta branch due to: Merge conflicts with dev branch

Please resolve this issue to include this PR in the next beta release.

opencode-agent · 2026-04-17T20:26:11Z

⚠️Blocking Beta Release

This PR cannot be merged into the beta branch due to: Merge conflicts with dev branch

Please resolve this issue to include this PR in the next beta release.

opencode-agent · 2026-04-17T23:23:35Z

⚠️Blocking Beta Release

This PR cannot be merged into the beta branch due to: Merge conflicts with dev branch

Please resolve this issue to include this PR in the next beta release.

opencode-agent · 2026-04-18T03:17:17Z

⚠️Blocking Beta Release

This PR cannot be merged into the beta branch due to: Merge conflicts with dev branch

Please resolve this issue to include this PR in the next beta release.

opencode-agent · 2026-04-18T07:37:29Z

⚠️Blocking Beta Release

This PR cannot be merged into the beta branch due to: Merge conflicts with dev branch

Please resolve this issue to include this PR in the next beta release.

opencode-agent · 2026-04-18T15:24:24Z

⚠️Blocking Beta Release

This PR cannot be merged into the beta branch due to: Merge conflicts with dev branch

Please resolve this issue to include this PR in the next beta release.

opencode-agent · 2026-04-18T20:20:58Z

⚠️Blocking Beta Release

This PR cannot be merged into the beta branch due to: Merge conflicts with dev branch

Please resolve this issue to include this PR in the next beta release.

opencode-agent · 2026-04-18T21:19:14Z

⚠️Blocking Beta Release

This PR cannot be merged into the beta branch due to: Merge conflicts with dev branch

Please resolve this issue to include this PR in the next beta release.

opencode-agent · 2026-04-19T01:46:34Z

⚠️Blocking Beta Release

This PR cannot be merged into the beta branch due to: Merge conflicts with dev branch

Please resolve this issue to include this PR in the next beta release.

opencode-agent · 2026-04-19T06:47:18Z

⚠️Blocking Beta Release

This PR cannot be merged into the beta branch due to: Merge conflicts with dev branch

Please resolve this issue to include this PR in the next beta release.

opencode-agent · 2026-04-19T07:42:03Z

⚠️Blocking Beta Release

This PR cannot be merged into the beta branch due to: Merge conflicts with dev branch

Please resolve this issue to include this PR in the next beta release.

opencode-agent · 2026-04-19T11:22:37Z

⚠️Blocking Beta Release

This PR cannot be merged into the beta branch due to: Merge conflicts with dev branch

Please resolve this issue to include this PR in the next beta release.

opencode-agent · 2026-04-19T19:25:28Z

⚠️Blocking Beta Release

This PR cannot be merged into the beta branch due to: Merge conflicts with dev branch

Please resolve this issue to include this PR in the next beta release.

opencode-agent · 2026-04-20T00:15:50Z

⚠️Blocking Beta Release

This PR cannot be merged into the beta branch due to: Merge conflicts with dev branch

Please resolve this issue to include this PR in the next beta release.

opencode-agent · 2026-04-20T07:05:58Z

⚠️Blocking Beta Release

This PR cannot be merged into the beta branch due to: Merge conflicts with dev branch

Please resolve this issue to include this PR in the next beta release.

opencode-agent · 2026-04-20T07:51:03Z

⚠️Blocking Beta Release

This PR cannot be merged into the beta branch due to: Merge conflicts with dev branch

Please resolve this issue to include this PR in the next beta release.

opencode-agent · 2026-04-20T09:01:38Z

⚠️Blocking Beta Release

This PR cannot be merged into the beta branch due to: Merge conflicts with dev branch

Please resolve this issue to include this PR in the next beta release.

MakonnenMak · 2026-04-20T17:39:35Z

Closing this since the original UI bug is now fixed upstream in #23093.

This PR also included a prompt.ts loop-exit fix, but at this point the branch has diverged heavily and the remaining change is better handled as a smaller follow-up PR if still needed.

MakonnenMak requested a review from adamdotdevin as a code owner February 19, 2026 16:44

github-actionsBot added needs:compliance This means the issue will auto-close after 2 hours. and removed needs:compliance This means the issue will auto-close after 2 hours. labels Feb 19, 2026

MakonnenMak mentioned this pull request Feb 19, 2026
Running opencode web in remote dev workspaces(coder.com), looking for setup advice #13011
Closed

alexyaroshuk reviewed Feb 19, 2026
View reviewed changes

MakonnenMak force-pushed the fix/clock-skew-prompt-loop-exit branch from 0e734cb to 6f428edCompare February 19, 2026 18:48

MakonnenMak requested a review from alexyaroshuk February 19, 2026 18:57

MakonnenMak force-pushed the fix/clock-skew-prompt-loop-exit branch from 6f428ed to fc258eaCompare February 20, 2026 18:20

adamdotdevin assigned rekram1-node Feb 27, 2026

adamdotdevin requested review from rekram1-node and removed request for alexyaroshuk February 27, 2026 11:36

adamdotdevin added the beta label Feb 27, 2026

opencode-agentBot added a commit that referenced this pull request Feb 27, 2026
Apply PR#14307: fix: use parentID matching instead of ID ordering fo…
f273ecd
…r prompt loop exit and message rendering

opencode-agentBot added a commit that referenced this pull request Feb 27, 2026
Apply PR#14307: fix: use parentID matching instead of ID ordering fo…
e6f7034
…r prompt loop exit and message rendering

opencode-agentBot added a commit that referenced this pull request Feb 27, 2026
Apply PR#14307: fix: use parentID matching instead of ID ordering fo…
d50f94e
…r prompt loop exit and message rendering

opencode-agentBot added a commit that referenced this pull request Feb 27, 2026
Apply PR#14307: fix: use parentID matching instead of ID ordering fo…
2bc6e98
…r prompt loop exit and message rendering

opencode-agentBot added a commit that referenced this pull request Feb 27, 2026
Apply PR#14307: fix: use parentID matching instead of ID ordering fo…
e8b1292
…r prompt loop exit and message rendering

opencode-agentBot added a commit that referenced this pull request Feb 27, 2026
Apply PR#14307: fix: use parentID matching instead of ID ordering fo…
81e9a8c
…r prompt loop exit and message rendering

opencode-agentBot added a commit that referenced this pull request Feb 27, 2026
Apply PR#14307: fix: use parentID matching instead of ID ordering fo…
6f27c88
…r prompt loop exit and message rendering

opencode-agentBot added a commit that referenced this pull request Feb 27, 2026
Apply PR#14307: fix: use parentID matching instead of ID ordering fo…
bbf2da0
…r prompt loop exit and message rendering

opencode-agentBot added a commit that referenced this pull request Feb 27, 2026
Apply PR#14307: fix: use parentID matching instead of ID ordering fo…
29d29f5
…r prompt loop exit and message rendering

opencode-agentBot added a commit that referenced this pull request Feb 27, 2026
Apply PR#14307: fix: use parentID matching instead of ID ordering fo…
aa8dbb7
…r prompt loop exit and message rendering

opencode-agentBot added a commit that referenced this pull request Feb 27, 2026
Apply PR#14307: fix: use parentID matching instead of ID ordering fo…
0f849f7
…r prompt loop exit and message rendering

Merge remote-tracking branch 'upstream/dev' into fix/clock-skew-promp…
291e168
…t-loop-exit # Conflicts: # packages/opencode/src/session/prompt.ts

This was referenced Apr 7, 2026
fix(session): use parentID instead of timestamp for loop exit condition #21334
Closed
fix(session): use parentID instead of timestamp for loop exit condition #21365
Open

heimoshuiyu mentioned this pull request Apr 17, 2026
Bug: Assistant messages invisible in web UI when client clock is ahead of server #23092
Closed

Uh oh!

Conversation

MakonnenMak commented Feb 19, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue for this PR

Type of change

What does this PR do?

How did you verify your code works?

Screenshots / recordings

Checklist

Uh oh!

github-actionsBot commented Feb 19, 2026

Uh oh!

github-actionsBot commented Feb 19, 2026

Uh oh!

alexyaroshukFeb 19, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MakonnenMakFeb 19, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MakonnenMakFeb 19, 2026

Choose a reason for hiding this comment

Uh oh!

MakonnenMak commented Feb 20, 2026

Uh oh!

alexyaroshuk commented Feb 20, 2026

Uh oh!

MakonnenMak commented Feb 21, 2026

Uh oh!

MakonnenMak commented Feb 24, 2026

Uh oh!

adamdotdevin commented Feb 27, 2026

Uh oh!

sjqwert commented Apr 5, 2026

Uh oh!

MakonnenMak commented Apr 6, 2026

Uh oh!

opencode-agentBot commented Apr 16, 2026

Uh oh!

opencode-agentBot commented Apr 16, 2026

Uh oh!

opencode-agentBot commented Apr 17, 2026

Uh oh!

opencode-agentBot commented Apr 17, 2026

Uh oh!

opencode-agentBot commented Apr 17, 2026

Uh oh!

opencode-agentBot commented Apr 17, 2026

Uh oh!

opencode-agentBot commented Apr 17, 2026

Uh oh!

opencode-agentBot commented Apr 17, 2026

Uh oh!

opencode-agentBot commented Apr 17, 2026

Uh oh!

opencode-agentBot commented Apr 18, 2026

Uh oh!

opencode-agentBot commented Apr 18, 2026

Uh oh!

opencode-agentBot commented Apr 18, 2026

Uh oh!

opencode-agentBot commented Apr 18, 2026

Uh oh!

opencode-agentBot commented Apr 18, 2026

Uh oh!

opencode-agentBot commented Apr 19, 2026

Uh oh!

opencode-agentBot commented Apr 19, 2026

Uh oh!

opencode-agentBot commented Apr 19, 2026

Uh oh!

opencode-agentBot commented Apr 19, 2026

Uh oh!

opencode-agentBot commented Apr 19, 2026

Uh oh!

opencode-agentBot commented Apr 20, 2026

Uh oh!

MakonnenMak commented Feb 19, 2026•
edited
Loading

alexyaroshukFeb 19, 2026•
edited
Loading

MakonnenMakFeb 19, 2026•
edited
Loading