Uh oh!
There was an error while loading. Please reload this page.
fix(opencode): add thinking variants support for SAP AI provider - #14958
Merged
rekram1-node merged 40 commits intoMar 10, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for Gemini 2.5 models' reasoning capabilities when accessed through SAP AI providers (@mymediset/sap-ai-provider and @jerome-benoit/sap-ai-provider-v2). Previously, these models fell through to a generic reasoningEffort fallback which doesn't work for Gemini models, which require the thinkingConfig format instead.
Changes:
- Added Gemini 2.5 detection logic for SAP AI providers that returns
thinkingConfigwiththinkingBudgetvalues matching the native@ai-sdk/googleprovider - Enables proper reasoning support for Gemini 2.5 Pro/Flash models when proxied through SAP AI Core
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
jerome-benoitforce-pushed
the
fix/sap-ai-gemini-thinking-variants
branch
3 times, most recently
from
February 24, 2026 22:08
419fcc2 to
e82a204Compare…iders SAP AI providers now correctly handle Gemini 2.5 models with thinkingConfig instead of falling back to reasoningEffort which doesn't work for Gemini. Fixesanomalyco#14957
jerome-benoitforce-pushed
the
fix/sap-ai-gemini-thinking-variants
branch
from
February 24, 2026 22:13
e82a204 to
374b84eCompareContributor
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Use word boundary (\b) instead of --o pattern to correctly match o1, o3, o3-mini models.
jerome-benoitforce-pushed
the
fix/sap-ai-gemini-thinking-variants
branch
from
February 25, 2026 00:04
74ded42 to
7b72411Compare
…ovider - Add isAnthropicAdaptive detection for Claude 4.6 models - Keep Gemini 2.5 thinkingConfig support - Keep GPT/o-series reasoningEffort support - Return empty object for unsupported models instead of fallback - Add unit test for Claude 4.6 adaptive thinking
jerome-benoit added a commit
to jerome-benoit/dotfiles
that referenced
this pull request
Mar 2, 2026
… and bun provider tracking Cherry-pick three upstream PRs: - anomalyco/opencode#14958: add thinking variant support for SAP AI provider - anomalyco/opencode#12822: remove Env namespace, use direct process.env access - anomalyco/opencode#10275: track provider packages with reference counting for cleanup
rekram1-node
commented
Mar 10, 2026
Collaborator
been on vacation for 2 weeks just got back |
Uh oh!
There was an error while loading. Please reload this page.
demostanis pushed a commit
to demostanis/opencode
that referenced
this pull request
Mar 19, 2026
…malyco#14958) Co-authored-by: Test <test@test.com> Co-authored-by: Stephen Collings <stevoland@gmail.com>
demostanis pushed a commit
to demostanis/opencode
that referenced
this pull request
Mar 20, 2026
…malyco#14958) Co-authored-by: Test <test@test.com> Co-authored-by: Stephen Collings <stevoland@gmail.com>
balcsida pushed a commit
to balcsida/opencode
that referenced
this pull request
Mar 24, 2026
…malyco#14958) Co-authored-by: Test <test@test.com> Co-authored-by: Stephen Collings <stevoland@gmail.com>
balcsida pushed a commit
to balcsida/opencode
that referenced
this pull request
Apr 8, 2026
…malyco#14958) Co-authored-by: Test <test@test.com> Co-authored-by: Stephen Collings <stevoland@gmail.com>
xywsxp pushed a commit
to xywsxp/opencode
that referenced
this pull request
Apr 24, 2026
…malyco#14958) Co-authored-by: Test <test@test.com> Co-authored-by: Stephen Collings <stevoland@gmail.com>
Rwanbt pushed a commit
to Rwanbt/unifia
that referenced
this pull request
May 5, 2026
…malyco#14958) Co-authored-by: Test <test@test.com> Co-authored-by: Stephen Collings <stevoland@gmail.com>
AIALRA-0 pushed a commit
to AIALRA-0/opencode-turn-engine
that referenced
this pull request
Jun 10, 2026
…malyco#14958) Co-authored-by: Test <test@test.com> Co-authored-by: Stephen Collings <stevoland@gmail.com>
AIALRA-0 pushed a commit
to AIALRA-0/opencode-turn-engine
that referenced
this pull request
Jun 10, 2026
…malyco#14958) Co-authored-by: Test <test@test.com> Co-authored-by: Stephen Collings <stevoland@gmail.com>
avion23 pushed a commit
to avion23/opencode
that referenced
this pull request
Jun 10, 2026
…malyco#14958) Co-authored-by: Test <test@test.com> Co-authored-by: Stephen Collings <stevoland@gmail.com>
Rwanbt pushed a commit
to Rwanbt/unifia
that referenced
this pull request
Jun 14, 2026
…malyco#14958) Co-authored-by: Test <test@test.com> Co-authored-by: Stephen Collings <stevoland@gmail.com>
MarsQiu007 referenced
this pull request
in MarsQiu007/openNovel
Jul 31, 2026
…958) Co-authored-by: Test <test@test.com> Co-authored-by: Stephen Collings <stevoland@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes#14957
Type of change
What does this PR do?
Adds proper thinking/reasoning variant support for SAP AI provider (
@jerome-benoit/sap-ai-provider-v2), harmonized with existing transverse variant handling.Changes:
isAnthropicAdaptivedetection (transverse variable at line 336) to apply{ thinking: { type: "adaptive" }, effort }config, matching@ai-sdk/anthropicand@ai-sdk/amazon-bedrockimplementations{ thinkingConfig: { includeThoughts: true, thinkingBudget } }with budget values matching@ai-sdk/googleprovider{ reasoningEffort }for OpenAI-compatible reasoning{}instead of incorrectreasoningEffortfallbackThe implementation reuses existing constants (
adaptiveEfforts,WIDELY_SUPPORTED_EFFORTS) and follows the established pattern from other provider cases.How did you verify your code works?
Screenshots / recordings
N/A - no UI changes
Checklist