fix: resolve multiple memory leaks causing unbounded growth by binarydoubling · Pull Request #16695 · anomalyco/opencode

binarydoubling · 2026-03-09T05:21:01Z

Issue for this PR

Type of change

Bug fix
New feature
Refactor / code improvement
Documentation

What does this PR do?

Fixes multiple sources of unbounded memory growth across the TUI, core subsystems, and server-side components. These leaks compound during extended usage causing RAM to climb monotonically.

TUI event listener leaks:

app.tsx: 6 sdk.event.on() calls had no cleanup — listeners accumulated on re-render. Now collected and unsubscribed via onCleanup.
session/index.tsx: message.part.updated listener accumulated every time a session was opened. Added onCleanup.
prompt/index.tsx: PromptAppend listener leaked on prompt remount. Added onCleanup.
theme.tsx: process.on("SIGUSR2") handler never removed. Now cleaned up via onCleanup.
keybind.tsx: Leader mode timeout never cleared on provider unmount. Added onCleanup.
sdk.tsx: Event queue not cleared on context cleanup. Now zeroed out.

Core memory leaks:

sdk.tsx: Event queue grew unbounded — capped at 1000 with oldest-event eviction.
sync.tsx: Message trimming only removed 1 message at a time and leaked associated parts. Now removes all excess and cleans up parts. Session switching now frees previous session's data.
lsp/client.ts: Diagnostics map grew without bound — added 200-file cap with LRU eviction, early return on empty diagnostics, and clear on shutdown.
session/prompt.ts: Pending callbacks not rejected on cancel — now rejected to prevent promise/closure leaks.
project/state.ts: Warning timeout in disposal never cleared — now cleared after disposal completes.
provider/models.ts: Module-level setInterval for model refresh never cleared — now cleared on process exit.
share/share-next.ts: Added dispose() to clear pending sync timeouts.

Collection cleanup:

bus/index.ts: Empty subscription arrays left as tombstones after unsubscribe — now deleted.
util/rpc.ts: Empty listener Sets left in map after handler removal — now deleted.
pty/index.ts: Session buffer not cleared on removal — now zeroed to free memory immediately.

How did you verify your code works?

Ran the TUI against a large monorepo, switched between sessions repeatedly, and monitored RSS over ~30 minutes. Memory stabilized instead of growing monotonically. Typechecks pass cleanly.

Screenshots / recordings

N/A — not a UI change

Checklist

I have tested my changes locally
I have not included unrelated changes in this PR

github-actions · 2026-03-09T05:21:10Z

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

Open an issue describing the bug/feature (if one doesn't exist)
Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

github-actions · 2026-03-09T05:21:41Z

The following comment was made by an LLM, it may be inaccurate:

Based on my search, I found several related PRs that address memory leaks:

Potentially Related PRs:

PR fix(opencode): unbounded memory growth during active usage #16346 - fix(opencode): unbounded memory growth during active usage
- Directly addresses unbounded memory growth similar to this PR
PR fix(lsp): ignore stderr on LSP server spawn to prevent unbounded memory growth #16241 - fix(lsp): ignore stderr on LSP server spawn to prevent unbounded memory growth
- Addresses memory growth in LSP specifically
PR fix: add LRU eviction to LSP client file and diagnostics tracking #7050 - fix: add LRU eviction to LSP client file and diagnostics tracking
- Implements LRU eviction for LSP diagnostics (similar to the diagnostics map bounding in this PR)
PR feat: add startup cleanup and maintenance system #16628 - feat: add startup cleanup and maintenance system
- Related to cleanup/maintenance similar to the cleanup work in this PR
PR fix: resolve multiple memory leaks causing unbounded RAM growth ( Now passing: && Fixed failing tests for windows ) #13514 - fix: resolve multiple memory leaks causing unbounded RAM growth
- Very similar title suggesting it addresses related memory leak issues
PR fix: add idle-timeout Instance disposal for serve mode memory #16616 - fix: add idle-timeout Instance disposal for serve mode memory
- Related to instance disposal and memory management

These PRs may be addressing overlapping memory leak issues. You should verify if PR #16695 duplicates work from any of these, particularly #16346, #16241, #7050, or #13514.

github-actions · 2026-03-09T05:23:42Z

Thanks for updating your PR! It now meets our contributing guidelines. 👍

Addresses the remaining memory leaks identified in anomalyco#16697 by consolidating the best fixes from 23+ open community PRs into a single coherent changeset. Fixes consolidated from PRs: anomalyco#16695, anomalyco#16346, anomalyco#14650, anomalyco#15646, anomalyco#13186, anomalyco#10392, anomalyco#7914, anomalyco#9145, anomalyco#9146, anomalyco#7049, anomalyco#16616, anomalyco#16241 - Plugin subscriber stacking: unsub before re-subscribing in init() - Subagent deallocation: Session.remove() after task completion - SSE stream cleanup: centralized cleanup with done guard (3 endpoints) - Compaction data trimming: clear output/attachments on prune - Process exit cleanup: Instance.disposeAll() with 5s timeout - Serve cmd: graceful shutdown instead of blocking forever - Bash tool: ring buffer with 10MB cap instead of O(n²) concat - LSP index teardown: clear clients/broken/spawning on dispose - LSP open-files cap: evict oldest when >1000 tracked files - Format subscription: store and cleanup unsub handle - Permission/Question clearSession: reject pending on session delete - Session.remove() cleanup chain: FileTime, Permission, Question - ShareNext subscription cleanup: store unsub handles, cleanup on dispose - OAuth transport: close existing before replacing Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

binarydoubling · 2026-03-09T19:33:27Z

Update: Consolidated fixes from 23+ community PRs

I've reviewed every open memory leak PR referenced in #16697 and consolidated the best version of each fix into this branch. The latest commit (b395d19) adds 17 more files on top of the original 15, bringing the total to 30 files changed.

New fixes added (from community PRs)

Fix	Source PRs	Impact
Plugin subscriber stacking — `Bus.subscribeAll()` unsub before re-init	#16346, #7914	Prevents permanent wildcard listener accumulation
Subagent deallocation — `Session.remove()` after task completion	#14650	GB-scale savings in long sessions with many subagents
SSE stream cleanup — centralized `cleanup()` + `done` guard on 3 endpoints	#15646	Prevents leaked handlers/intervals on ungraceful disconnect
Compaction data trimming — clear `output` and `attachments` on prune	#14650, #7049	Frees 200KB+ per compacted tool call
Process exit cleanup — `Instance.disposeAll()` with 5s timeout in finally block	#13186, #15646	Prevents zombie LSP/MCP/PTY processes
Serve command — graceful shutdown instead of `await new Promise(() => {})`	#13186	Fixes unreachable cleanup code in serve mode
Bash tool ring buffer — chunks array with 10MB cap instead of `output += chunk`	#13186, #7914	Eliminates O(n²) string growth for long commands
LSP index teardown — clear `clients`/`broken`/`spawning` on dispose	#16346	Prevents stale client references after teardown
LSP open-files cap — evict oldest when >1000 tracked files	#14650	Prevents unbounded `files` object growth
Format subscription cleanup — store and cleanup unsub handle on re-init	#10392, #7914	Prevents listener stacking
Permission `clearSession()` — reject pending promises on session delete	#14650, #10392	Prevents leaked promises holding closures
Question `clearSession()` — reject pending promises on session delete	#10392, #13186	Same as above
Session.remove() cleanup chain — calls FileTime, Permission, Question cleanup	#10392	Per-session state freed on deletion
ShareNext subscription cleanup — store unsub handles, cleanup on dispose/re-init	#10392, #7914	Prevents 4 Bus listeners stacking per init cycle
OAuth transport close — close existing transport before replacing	#9145	Prevents abandoned HTTP transports accumulating

What's NOT in this PR (and why)

Some fixes from the community PRs were intentionally excluded:

Bun.gc() calls (fix(opencode): unbounded memory growth during active usage #16346, fix: resolve memory leaks and zombie processes from missing cleanup handlers #13186) — forcing GC is a band-aid; the actual leaks are fixed instead
Diagnostics/monitoring module (fix: prevent memory leaks from SSE streams, LSP, Bus, and process cleanup #15646) — good idea but out of scope for a leak fix PR
Instance idle-timeout with ref counting (fix: add idle-timeout Instance disposal for serve mode memory #16616) — valuable but architecturally significant; should be its own PR
LSP stderr "ignore" (fix(lsp): ignore stderr on LSP server spawn to prevent unbounded memory growth #16241) — changes 40+ spawn sites across server definitions; better as a targeted PR
LRU cache utility + provider cache bounds (fix(opencode): memory leaks in session handling #10392, fix(disposal): Complete Instance disposal chain for plugins and caches #9149) — new abstraction layer; merits separate review
ACP session manager TTL/eviction (fix(memory): add TTL, LRU eviction, and ring buffers to prevent memory leaks #12259, fix(acp): Fix memory leak in session event streams #9146) — requires design decision on TTL values
Startup cleanup/maintenance system (feat: add startup cleanup and maintenance system #16628) — new feature (config schema, vacuum, retention); should be separate
AsyncQueue close() (fix: address 6 memory leaks for long-running sessions #13594) — API change to a shared utility; needs its own review
O(n²) string concat in processor.ts (fix: resolve memory leaks and zombie processes from missing cleanup handlers #13186, fix(opencode): memory leaks in session handling #10392) — the throttled flush approach is complex; needs careful review to avoid breaking streaming UX
SDK SSE buffer cap / abort listener { once: true } (fix: resolve memory leak issues across multiple subsystems #14650) — changes are in packages/sdk/, not packages/opencode/; separate package, separate PR

Verification

tsgo --noEmit passes cleanly across all 19 packages
Pre-commit typecheck hook passed on push

Addresses the remaining memory leaks identified in anomalyco#16697 by consolidating the best fixes from 23+ open community PRs into a single coherent changeset. Fixes consolidated from PRs: anomalyco#16695, anomalyco#16346, anomalyco#14650, anomalyco#15646, - Plugin subscriber stacking: unsub before re-subscribing in init() - Subagent deallocation: Session.remove() after task completion - SSE stream cleanup: centralized cleanup with done guard (3 endpoints) - Compaction data trimming: clear output/attachments on prune - Process exit cleanup: Instance.disposeAll() with 5s timeout - Serve cmd: graceful shutdown instead of blocking forever - Bash tool: ring buffer with 10MB cap instead of O(n²) concat - LSP index teardown: clear clients/broken/spawning on dispose - LSP open-files cap: evict oldest when >1000 tracked files - Format subscription: store and cleanup unsub handle - Permission/Question clearSession: reject pending on session delete - Session.remove() cleanup chain: FileTime, Permission, Question - ShareNext subscription cleanup: store unsub handles, cleanup on dispose - OAuth transport: close existing before replacing Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

- Cap SDK event queue to prevent unbounded growth during high event throughput - Clean up message parts when trimming excess messages in sync store - Evict previous session data from memory when switching sessions - Bound LSP diagnostics map with LRU eviction and clear on shutdown - Reject pending callbacks on session cancel to prevent promise/closure leaks Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

- Add onCleanup for all sdk.event.on() listeners in app.tsx, session route, and prompt component to prevent listener accumulation on re-render - Add onCleanup for process SIGUSR2 handler in theme provider - Add onCleanup for leader timeout in keybind provider - Clear event queue on SDK context cleanup - Remove empty subscription arrays in Bus and RPC listener maps - Clear warning timeout in state disposal after completion - Clear models refresh interval on process exit - Add dispose() to ShareNext to clear pending sync timeouts - Clear PTY session buffer on removal to free memory immediately Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Addresses the remaining memory leaks identified in anomalyco#16697 by consolidating the best fixes from 23+ open community PRs into a single coherent changeset. Fixes consolidated from PRs: anomalyco#16695, anomalyco#16346, anomalyco#14650, anomalyco#15646, - Plugin subscriber stacking: unsub before re-subscribing in init() - Subagent deallocation: Session.remove() after task completion - SSE stream cleanup: centralized cleanup with done guard (3 endpoints) - Compaction data trimming: clear output/attachments on prune - Process exit cleanup: Instance.disposeAll() with 5s timeout - Serve cmd: graceful shutdown instead of blocking forever - Bash tool: ring buffer with 10MB cap instead of O(n²) concat - LSP index teardown: clear clients/broken/spawning on dispose - LSP open-files cap: evict oldest when >1000 tracked files - Format subscription: store and cleanup unsub handle - Permission/Question clearSession: reject pending on session delete - Session.remove() cleanup chain: FileTime, Permission, Question - ShareNext subscription cleanup: store unsub handles, cleanup on dispose - OAuth transport: close existing before replacing Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Port robust process exit detection from PR anomalyco#15757 to fix zombie/stuck child processes in containers where Bun fails to deliver exit events. - Add polling watchdog to bash tool and Process.spawn that detects process exit via kill(pid, 0) when event-loop events are missed - Add process registry (active map) with stale/reap exports for server-level watchdog to detect and clean up stuck bash processes - Improve Shell.killTree with alive() helper and proper SIGKILL escalation after SIGTERM timeout - Add session-level watchdog interval in prompt loop to periodically reap stale bash processes Based on the work in anomalyco#15757. Co-Authored-By: Nacho F. Lizaur <NachoFLizaur@users.noreply.github.com>

Complete the port of PR anomalyco#15757 with remaining pieces: - Add stdio end event redundancy as third fallback for exit detection (fires when pipe file descriptors close, independent of exit events) - Add diagnostic log.info calls at spawn, abort, timeout, and each exit detection path for debugging container issues - Add comprehensive tests: defensive patterns, polling watchdog isolation, Shell.killTree, server-level watchdog (stale/reap), stdio end events, and Process.spawn defensive patterns - Skip truncation tests on Windows (matching upstream) Co-Authored-By: Nacho F. Lizaur <NachoFLizaur@users.noreply.github.com>

On Windows, stdio pipe end events can fire before the exit event populates proc.exitCode, causing it to be null in the result metadata. Fall back to 0 (or 1 if signalCode is set) when exitCode is null, matching the same pattern used in Process.spawn. Co-Authored-By: Nacho F. Lizaur <NachoFLizaur@users.noreply.github.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Upstream changed pending from plain object to Map<BrandedID, PendingEntry>. Update clearSession() in permission and question modules to use Map iteration and .delete() instead of Object.entries() and delete. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Addresses the remaining memory leaks identified in anomalyco#16697 by consolidating the best fixes from 23+ open community PRs into a single coherent changeset. Fixes consolidated from PRs: anomalyco#16695, anomalyco#16346, anomalyco#14650, anomalyco#15646, - Plugin subscriber stacking: unsub before re-subscribing in init() - Subagent deallocation: Session.remove() after task completion - SSE stream cleanup: centralized cleanup with done guard (3 endpoints) - Compaction data trimming: clear output/attachments on prune - Process exit cleanup: Instance.disposeAll() with 5s timeout - Serve cmd: graceful shutdown instead of blocking forever - Bash tool: ring buffer with 10MB cap instead of O(n²) concat - LSP index teardown: clear clients/broken/spawning on dispose - LSP open-files cap: evict oldest when >1000 tracked files - Format subscription: store and cleanup unsub handle - Permission/Question clearSession: reject pending on session delete - Session.remove() cleanup chain: FileTime, Permission, Question - ShareNext subscription cleanup: store unsub handles, cleanup on dispose - OAuth transport: close existing before replacing Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…16695) Merges 14 branches into sami fork: Features: - feat(config): webMode/webUrl server config - feat(app): ?server= query param, direct-load mode - feat(app): continuous voice mode (VAD, state machine, barge-in, wake lock) - feat(session): custom session ID, messageCount endpoint - feat(session): index-based message ordering, hardened prompt loop - feat(plugin): skills accessor via PluginInput.skills - feat(plugin): last-wins auth override for user plugins - feat(bun): github ref plugins, dist-tag version resolution, model limit overrides - ci: sami-build workflow Fixes: - fix: memory leak fixes from PR anomalyco#16695 (binarydoubling), adapted to Effect APIs - PermissionNext.clearSession: reject pending permissions on session delete - Question.clearSession: reject pending question deferreds on session delete - FileTime.clearSession: clean up per-session file timestamp maps - TUI event listener cleanup via onCleanup + unsubs array - SSE stream cleanup with centralized stop/done guards (AsyncQueue pattern) - Plugin subscription cleanup via Effect acquireRelease - fix: instance idle-timeout disposal for serve mode - fix(tui): disposal recovery — bounded retry, session re-sync, fresh context - fix(tui): checkUpgrade error logging - fix: duplicate OPENCODE_WEB_URL flag declaration

Merges 15 branches into sami fork: Features: - feat(config): webMode/webUrl server config - feat(app): ?server= query param, direct-load mode - feat(app): continuous voice mode (VAD, state machine, barge-in, wake lock) - feat(session): custom session ID, messageCount endpoint - feat(session): index-based message ordering, hardened prompt loop - feat(plugin): skills accessor via PluginInput.skills - feat(plugin): last-wins auth override for user plugins - feat(bun): github ref plugins, dist-tag version resolution, model limit overrides - feat: memory telemetry sampler — periodic bun:jsc heapStats + objectTypeCounts - ci: sami-build workflow Fixes: - fix: memory leak fixes from PR anomalyco#16695 (binarydoubling), adapted to Effect APIs - fix: instance idle-timeout disposal for serve mode - fix(tui): disposal recovery, checkUpgrade error logging Telemetry: - Periodic memory sampler (5s interval, delta-based logging, 50MB threshold) - SIGTERM handler writes heap snapshot to /tmp - SIGUSR2 on-demand heap snapshot without exit

github-actions · 2026-05-13T06:56:52Z

Closing this pull request because it has had no updates for more than 60 days. If you plan to continue working on it, feel free to reopen or open a new PR.

gggiiia · 2026-06-02T21:00:59Z

+1 having big memory leaks using opencode

github-actionsBot added the needs:issue label Mar 9, 2026

github-actionsBot added the needs:compliance This means the issue will auto-close after 2 hours. label Mar 9, 2026

github-actionsBot removed the needs:compliance This means the issue will auto-close after 2 hours. label Mar 9, 2026

github-actionsBot removed the needs:issue label Mar 9, 2026

This was referenced Mar 10, 2026
📊 AI CLI 工具社区动态日报 2026-03-10 duanyytop/agents-radar#117
Closed
📊 AI CLI Tools Digest 2026-03-10 duanyytop/agents-radar#118
Closed

Stranmor mentioned this pull request Mar 11, 2026
fix(memory): add TTL, LRU eviction, and ring buffers to prevent memory leaks #12259
Closed
3 tasks

binarydoublingand others added 6 commits March 13, 2026 00:33

binarydoubling force-pushed the fix/memory-leaks branch from 3cc6ed9 to 3dee417Compare March 13, 2026 08:38

binarydoublingand others added 2 commits March 13, 2026 00:40

fix: correct SSE handler indentation after rebase conflict resolution
89cadd2
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

This was referenced Mar 15, 2026
fix: remove dead LSP clients to prevent unbounded memory growth #17627
Closed
fix: remove dead LSP clients to prevent unbounded memory growth #17630
Closed
fix: remove dead LSP clients to prevent unbounded memory growth #17635
Closed

github-actionsBot mentioned this pull request Mar 16, 2026
fix(run): await loop() before instance disposal #17825
Closed
3 tasks

github-actionsBot mentioned this pull request Apr 7, 2026
fix: bash tool memory leak #21321
Closed
3 tasks

opencode-agentBotforce-pushed the dev branch from 2f2ed11 to 9f201d6Compare April 16, 2026 21:55

github-actionsBot mentioned this pull request Apr 25, 2026
fix(opencode): resolve heap unlimited + orphan processes on Linux #24297
Closed
7 tasks

github-actionsBot closed this May 13, 2026

bashrusakh mentioned this pull request Jun 30, 2026
Tool execution timeout (300s) silently drops session — UI stuck on thinking with STOP button openchamber/openchamber#1950
Open

Navigation Menu

Uh oh!

fix: resolve multiple memory leaks causing unbounded growth - #16695

fix: resolve multiple memory leaks causing unbounded growth#16695
binarydoubling wants to merge 8 commits into
anomalyco:devfrom
binarydoubling:fix/memory-leaks

binarydoubling commented Mar 9, 2026•
edited
Loading

Uh oh!

github-actionsBot commented Mar 9, 2026

Uh oh!

github-actionsBot commented Mar 9, 2026

Uh oh!

github-actionsBot commented Mar 9, 2026

Uh oh!

binarydoubling commented Mar 9, 2026

Uh oh!

github-actionsBot commented May 13, 2026

Uh oh!

gggiiia commented Jun 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

binarydoubling commented Mar 9, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue for this PR

Type of change

What does this PR do?

How did you verify your code works?

Screenshots / recordings

Checklist

Uh oh!

github-actionsBot commented Mar 9, 2026

Uh oh!

github-actionsBot commented Mar 9, 2026

Uh oh!

github-actionsBot commented Mar 9, 2026

Uh oh!

binarydoubling commented Mar 9, 2026

Update: Consolidated fixes from 23+ community PRs

New fixes added (from community PRs)

What's NOT in this PR (and why)

Verification

Uh oh!

github-actionsBot commented May 13, 2026

Uh oh!

gggiiia commented Jun 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

binarydoubling commented Mar 9, 2026•
edited
Loading