Skip to content

feat(app) project icon handling - #16929

Closed
anduimagui wants to merge 18 commits into
anomalyco:devfrom
anduimagui:feat/icon-loading-config-clean
Closed

feat(app) project icon handling#16929
anduimagui wants to merge 18 commits into
anomalyco:devfrom
anduimagui:feat/icon-loading-config-clean

Conversation

@anduimagui

@anduimaguianduimagui commented Mar 10, 2026

Copy link
Copy Markdown

Issue for this PR

Refs #13843

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

This branch expands the original project icon work into a broader cleanup across the backend and app layers.

On the backend, it updates project icon discovery and precedence so .opencode assets are resolved more consistently, including support for .url sources and clearer fallback behavior.

On the app side, it makes project-specific icons render consistently in the sidebar, edit project flow, and new session view. It also extracts shared project avatar logic into a dedicated module so icon source resolution, avatar colors, and fallback behavior live in one place.

Because this branch has grown over time, the scope is now wider than the original PR title and description and should be reviewed as a cross-package icon/avatar update rather than a narrowly scoped backend-only change.

How did you verify your code works?

  • Ran repo typechecks through the push hook with bun turbo typecheck
  • Updated app-side tests for the shared project avatar helpers
  • Updated backend project icon tests in packages/opencode
  • Manually verified the new session view now uses the current project icon override instead of the default OpenCode mark

Screenshots / recordings

n/a

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

If you do not follow this template your PR will be automatically rejected.

@github-actionsgithub-actionsBot added the needs:compliance This means the issue will auto-close after 2 hours. label Mar 10, 2026
@github-actionsgithub-actionsBot removed the needs:compliance This means the issue will auto-close after 2 hours. label Mar 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

@anduimagui
anduimagui marked this pull request as ready for review March 11, 2026 08:29
@anduimaguianduimagui changed the title refactor(project): load icons from .opencode assetsfeat(project): load icons from .opencode assetsMar 15, 2026
@anduimaguianduimagui changed the title feat(project): load icons from .opencode assetsfeat(project): prioritize .opencode assets for icon discoveryMar 18, 2026
@anduimaguianduimagui changed the title feat(project): prioritize .opencode assets for icon discoveryfeat(app): load icons from .opencode assetsMar 18, 2026
Andrew Maguire added 2 commits March 19, 2026 13:54
Move shared project avatar logic into a dedicated module and update the sidebar and new session views to use the current project icon override — plus split the related tests into a focused file.
@anduimaguianduimagui changed the title feat(app): load icons from .opencode assetsrefactor project icon handling — align discovery, app rendering, and shared avatar helpersMar 19, 2026
@github-actionsgithub-actionsBot added needs:compliance This means the issue will auto-close after 2 hours. needs:title labels Mar 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hey! Your PR title refactor project icon handling — align discovery, app rendering, and shared avatar helpers doesn't follow conventional commit format.

Please update it to start with one of:

  • feat: or feat(scope): new feature
  • fix: or fix(scope): bug fix
  • docs: or docs(scope): documentation changes
  • chore: or chore(scope): maintenance tasks
  • refactor: or refactor(scope): code refactoring
  • test: or test(scope): adding or updating tests

Where scope is the package name (e.g., app, desktop, opencode).

See CONTRIBUTING.md for details.

@github-actionsgithub-actionsBot removed the needs:compliance This means the issue will auto-close after 2 hours. label Mar 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

@anduimaguianduimagui changed the title refactor project icon handling — align discovery, app rendering, and shared avatar helpersfeat(desktop) project icon handlingMar 19, 2026
@anduimaguianduimagui changed the title feat(desktop) project icon handlingfeat(app) project icon handlingMar 19, 2026
@hab33bi

Copy link
Copy Markdown

For whatever reason, the icon saving system is broken for me, I try to set a png (high quality as the icon) and it does not save. Windows 11. Latest OpenCode. Reopen this.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@anduimagui@hab33bi