Skip to content

refactor(instance): move scoped services to LayerMap - #17542

Closed
kitlangton wants to merge 2 commits into
devfrom
effectify-file-watcher
Closed

refactor(instance): move scoped services to LayerMap#17542
kitlangton wants to merge 2 commits into
devfrom
effectify-file-watcher

Conversation

@kitlangton

Copy link
Copy Markdown
Contributor

Summary

  • move question, permission, and provider auth onto a shared per-instance LayerMap, and add runPromiseInstance for the common runtime wiring
  • replace InstanceState with closure-backed service state and a lightweight instance disposal bridge, while keeping provider auth as an Effect service and breaking the plugin cycle with a targeted dynamic import
  • update the affected tests for the new instance-scoped behavior and remove the old InstanceState tests

Testing

  • bun typecheck
  • bun run test test/question/ test/permission/next.test.ts test/provider/auth.test.ts test/plugin/auth-override.test.ts

@kitlangton

Copy link
Copy Markdown
ContributorAuthor

Superseded by #17544 (same branch, with test fix)

@kitlangton
kitlangton deleted the effectify-file-watcher branch March 15, 2026 13:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@kitlangton