Uh oh!
There was an error while loading. Please reload this page.
refactor(effect): yield services instead of promise facades - #19325
Merged
Conversation
kitlangtonforce-pushed
the
effect/yield-services
branch
from
March 26, 2026 18:31
87b8db5 to
b976561Comparekitlangtonforce-pushed
the
effect/yield-services
branch
from
March 26, 2026 18:55
b976561 to
7bf7d51CompareEffectified services now yield other effectified services directly via their Effect interface instead of going through async promise facades (Effect.promise(() => Service.method())). This keeps the full call chain within the Effect runtime, enabling proper dependency tracking and avoiding unnecessary runtime boundary crossings. Services updated: Agent, Command, Config, FileWatcher, Format, LSP, MCP, Pty, Snapshot, Worktree. Also: - CrossSpawnSpawner: add defaultLayer (provides NodeFileSystem + NodePath) - Worktree: use AppFileSystem instead of raw FileSystem.FileSystem - Project: rename fsys → fs for consistency - Update effect-migration.md checklist and scope lists
kitlangtonforce-pushed
the
effect/yield-services
branch
from
March 26, 2026 18:58
7bf7d51 to
cbd472fComparekitlangton
marked this pull request as ready for review
March 26, 2026 18:59
Uh oh!
There was an error while loading. Please reload this page.
CopilotAI
pushed a commit
to ian-morgan99/opencode
that referenced
this pull request
Mar 28, 2026
…o#19325) Co-authored-by: ian-morgan99 <106852423+ian-morgan99@users.noreply.github.com>
balcsida pushed a commit
to balcsida/opencode
that referenced
this pull request
Apr 8, 2026
xywsxp pushed a commit
to xywsxp/opencode
that referenced
this pull request
Apr 24, 2026
Rwanbt pushed a commit
to Rwanbt/unifia
that referenced
this pull request
May 5, 2026
AIALRA-0 pushed a commit
to AIALRA-0/opencode-turn-engine
that referenced
this pull request
Jun 10, 2026
AIALRA-0 pushed a commit
to AIALRA-0/opencode-turn-engine
that referenced
this pull request
Jun 10, 2026
avion23 pushed a commit
to avion23/opencode
that referenced
this pull request
Jun 10, 2026
Rwanbt pushed a commit
to Rwanbt/unifia
that referenced
this pull request
Jun 14, 2026
MarsQiu007 referenced
this pull request
in MarsQiu007/openNovel
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Effect.promise(() => Service.method())). This keeps the full call chain within the Effect runtime.Config.get()through a promise wrapperdefaultLayerthat provides NodeFileSystem + NodePath, so consumers don't need to wire those manuallyFileSystem.FileSystemtoAppFileSystem.ServiceServices updated
Agent, Command, Config, FileWatcher, Format, LSP, MCP, Pty, Snapshot, Worktree
Cross-service promise calls converted
Effect.promise()Effect.promise()Effect.promise()Effect.promise()/ closureEffect.promise()Effect.promise()Test plan
bun run typecheckpasses (0 errors)